Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 364193003: When building APK for direct loading, check for multiple libraries. (Closed)

Created:
6 years, 5 months ago by Anton
Modified:
6 years, 5 months ago
Reviewers:
anton1, Sami
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, Miguel Garcia, simonb (inactive)
Project:
chromium
Visibility:
Public.

Description

When building APK for direct loading, check for multiple libraries. Explicitly check for multiple libraries. This gives the developer a less cryptic error message. In particular, I mentioned that a clean build may be required. BUG=388223 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281295

Patch Set 1 #

Total comments: 2

Patch Set 2 : Check for multiple libraries, fix comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M build/android/rezip/rezip.cc View 1 3 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
anton1
6 years, 5 months ago (2014-07-03 13:30:17 UTC) #1
anton1
6 years, 5 months ago (2014-07-03 13:34:55 UTC) #2
Sami
This for making this more explicit. lgtm. https://codereview.chromium.org/364193003/diff/1/build/android/rezip/rezip.cc File build/android/rezip/rezip.cc (right): https://codereview.chromium.org/364193003/diff/1/build/android/rezip/rezip.cc#newcode265 build/android/rezip/rezip.cc:265: // Also ...
6 years, 5 months ago (2014-07-03 13:38:48 UTC) #3
anton1
https://codereview.chromium.org/364193003/diff/1/build/android/rezip/rezip.cc File build/android/rezip/rezip.cc (right): https://codereview.chromium.org/364193003/diff/1/build/android/rezip/rezip.cc#newcode265 build/android/rezip/rezip.cc:265: // Also enforce that only one library is On ...
6 years, 5 months ago (2014-07-03 13:45:10 UTC) #4
anton1
The CQ bit was checked by anton@google.com
6 years, 5 months ago (2014-07-03 13:46:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/anton@chromium.org/364193003/20001
6 years, 5 months ago (2014-07-03 13:47:00 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-03 15:35:09 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-03 17:45:57 UTC) #8
Message was sent while issue was closed.
Change committed as 281295

Powered by Google App Engine
This is Rietveld 408576698