Cursor does not blink on longpress in an emptyField.

Cursor does not blink on longpress in an emptyField.

When we long press on any input field containing any text,
sendContextMenuEventForGesture gets called and context menu is displayed
providing us the options to cut, copy, paste etc.

But when we long press on any empty field, the caret blinking gets suspended and
even after typing some text, the cursor remains in suspended state and unless we
tap on the input field, it's not set back to false. So, in case of longpress
scenario, it was never set back to false and due to this cursor does not blink
for any operations which is done after longpress. So, we handle the case now and
setCaretBlinkingSuspended to false when context menu event is sent.

BUG=386331
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178735

[Sunil Ratnu, 2014-07-03 10:26:57]

Please take a look.

[tkent, 2014-07-04 03:08:04]

> But when we long press on any empty field, the caret blinking gets suspended
and
> even after typing some text, the cursor remains in suspended state and unless
we

Why is the caret blinking suspended in this case?

[Inactive, 2014-07-15 16:02:47]

https://codereview.chromium.org/364193002/diff/1/Source/core/page/EventHandle...
File Source/core/page/EventHandler.cpp (right):

https://codereview.chromium.org/364193002/diff/1/Source/core/page/EventHandle...
Source/core/page/EventHandler.cpp:2641: // Clear caret blinking suspended state
to make sure that mourse blinks
s/mourse/caret

[Sunil Ratnu, 2014-07-15 17:10:56]

Thanks Chris and tkent for the review. Sorry for the delay in reply.
@tkent: The caret blinking gets suspended because:
In case of android, the user is provided with an option to cut/copy/paste (in
case of long pressing on text fields having some text) and option for paste (in
case of empty text field).
In case of desktop, the user is provided with and option to drag the mouse and
select some text. Hence, we make the caret blinking supended. It is only cleared
in case of a mouse release event. It should also be cleared in cases as
mentioned in the bug.

https://codereview.chromium.org/364193002/diff/1/Source/core/page/EventHandle...
File Source/core/page/EventHandler.cpp (right):

https://codereview.chromium.org/364193002/diff/1/Source/core/page/EventHandle...
Source/core/page/EventHandler.cpp:2641: // Clear caret blinking suspended state
to make sure that mourse blinks
On 2014/07/15 16:02:46, Chris Dumez wrote:
> s/mourse/caret

Done.

[tkent, 2014-07-16 07:48:11]

ok, I understand.

Please add a unit test.

[Sunil Ratnu, 2014-07-21 12:28:09]

On 2014/07/16 07:48:11, tkent wrote:
> ok, I understand.
> 
> Please add a unit test.

I've added the unit test case. PTAL.

[tkent, 2014-07-22 01:37:55]

lgtm

[commit-bot: I haz the power, 2014-07-22 01:38:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/364193002/40001

[commit-bot: I haz the power, 2014-07-22 02:31:43]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_db...)
  android_blink_compile_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_re...)

[commit-bot: I haz the power, 2014-07-22 02:51:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-22 02:51:24]

Try jobs failed on following builders:
  android_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_db...)
  android_blink_compile_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_re...)

[Sunil Ratnu, 2014-07-22 10:42:28]

On 2014/07/22 02:51:24, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   android_blink_compile_dbg on tryserver.blink
>
(http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_db...)
>   android_blink_compile_rel on tryserver.blink
>
(http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_re...)

Hi tkent, Thanks for the review.
I've changed the place where we set CaretBlinkingSuspended = false as compared
to the earlier approach because the earlier approach had one side effect: The
cursor kept blinking when context menu was up, but now we handle that case and
caret only starts blinking when we start typing again.
Please have a look at it once again before the commit. Thanks!

[tkent, 2014-07-22 23:30:10]

lgtm

[commit-bot: I haz the power, 2014-07-23 03:20:26]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-07-23 04:57:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-23 04:57:51]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[tkent, 2014-07-23 04:59:08]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2014-07-23 05:00:00]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/364193002/80001

[commit-bot: I haz the power, 2014-07-23 05:46:59]

Change committed as 178735