Source/core/dom/Document.cpp - Issue 364173005: Document.adoptNode should not throw an exception for DocumentType argument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Document.cpp

Issue 364173005: Document.adoptNode should not throw an exception for DocumentType argument (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/Document.cpp

diff --git a/Source/core/dom/Document.cpp b/Source/core/dom/Document.cpp

index 48013d58a1922b32848c0cae2a650a12565899e0..8dc27ab3d2c3d7ec143ed22a1e46a3ef5d89bd2b 100644

--- a/Source/core/dom/Document.cpp

+++ b/Source/core/dom/Document.cpp

@@ -1008,7 +1008,6 @@ PassRefPtrWillBeRawPtr<Node> Document::adoptNode(PassRefPtrWillBeRawPtr<Node> so

switch (source->nodeType()) {

case DOCUMENT_NODE:

- case DOCUMENT_TYPE_NODE:

exceptionState.throwDOMException(NotSupportedError, "The node provided is of type '" + source->nodeName() + "', which may not be adopted.");

return nullptr;

case ATTRIBUTE_NODE: {

« no previous file with comments | « LayoutTests/fast/dom/Document/adopt-node-with-doctype-expected.txt ('k') | no next file » | no next file with comments »