Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 364173005: Document.adoptNode should not throw an exception for DocumentType argument (Closed)

Created:
6 years, 5 months ago by kangil_
Modified:
6 years, 5 months ago
Reviewers:
tkent, haraken
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Document.adoptNode should not throw an exception for DocumentType argument According to spec, Document.adoptNode only throws exception on document. spec: http://dom.spec.whatwg.org/#dom-document-adoptnode *)If node is a document, throw a "NotSupportedError" exception. So this CL modified behavior as per specified. TEST=LayoutTests/fast/dom/Document/adopt-node-with-doctype.html In addition, with this CL, http://w3c-test.org/dom/nodes/Document-adoptNode.html will be passed. Behavior in other browsers: *)FF: pass *)IE: fail Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177501

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -607 lines) Patch
D LayoutTests/dom/xhtml/level3/core/documentadoptnode10.js View 1 chunk +0 lines, -118 lines 0 comments Download
D LayoutTests/dom/xhtml/level3/core/documentadoptnode10.xhtml View 1 chunk +0 lines, -73 lines 0 comments Download
D LayoutTests/dom/xhtml/level3/core/documentadoptnode10-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/dom/xhtml/level3/core/documentadoptnode11.js View 1 chunk +0 lines, -129 lines 0 comments Download
D LayoutTests/dom/xhtml/level3/core/documentadoptnode11.xhtml View 1 chunk +0 lines, -73 lines 0 comments Download
D LayoutTests/dom/xhtml/level3/core/documentadoptnode11-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/dom/xhtml/level3/core/documentadoptnode12.js View 1 chunk +0 lines, -134 lines 0 comments Download
D LayoutTests/dom/xhtml/level3/core/documentadoptnode12.xhtml View 1 chunk +0 lines, -73 lines 0 comments Download
D LayoutTests/dom/xhtml/level3/core/documentadoptnode12-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
A LayoutTests/fast/dom/Document/adopt-node-with-doctype.html View 1 chunk +22 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/Document/adopt-node-with-doctype-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
kangil_
PTAL, thanks!
6 years, 5 months ago (2014-07-03 12:21:50 UTC) #1
haraken
LGTM, but tkent-san would want to confirm about the behavior change.
6 years, 5 months ago (2014-07-03 12:27:19 UTC) #2
kangil_
On 2014/07/03 12:27:19, haraken wrote: > LGTM, but tkent-san would want to confirm about the ...
6 years, 5 months ago (2014-07-03 12:42:58 UTC) #3
tkent
lgtm. I think the behavior change is safe because DocumentType nodes are rarely used. CL ...
6 years, 5 months ago (2014-07-04 01:59:01 UTC) #4
kangil_
On 2014/07/04 01:59:01, tkent wrote: > lgtm. > I think the behavior change is safe ...
6 years, 5 months ago (2014-07-04 02:03:39 UTC) #5
kangil_
The CQ bit was checked by kangil.han@samsung.com
6 years, 5 months ago (2014-07-04 02:03:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kangil.han@samsung.com/364173005/1
6 years, 5 months ago (2014-07-04 02:04:20 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-04 02:52:56 UTC) #8
Message was sent while issue was closed.
Change committed as 177501

Powered by Google App Engine
This is Rietveld 408576698