Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1993)

Unified Diff: Source/devtools/front_end/timeline/TimelinePanel.js

Issue 364153002: DevTools: Timeline: do not force lazyTimelineView to be created. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/timeline/TimelinePanel.js
diff --git a/Source/devtools/front_end/timeline/TimelinePanel.js b/Source/devtools/front_end/timeline/TimelinePanel.js
index 5f77ffa6c60cb63bad221aeab0c84737ffd50cd4..47da433e0cf3a37cc53746823808581a9665ace9 100644
--- a/Source/devtools/front_end/timeline/TimelinePanel.js
+++ b/Source/devtools/front_end/timeline/TimelinePanel.js
@@ -328,7 +328,6 @@ WebInspector.TimelinePanel.prototype = {
_createRecordingOptions: function()
{
var topPaneSidebarElement = this._topPane.sidebarElement();
-
this._captureStacksSetting = WebInspector.settings.createSetting("timelineCaptureStacks", true);
topPaneSidebarElement.appendChild(WebInspector.SettingsUI.createSettingCheckbox(WebInspector.UIString("Capture stacks"),
this._captureStacksSetting, true, undefined,
@@ -656,7 +655,9 @@ WebInspector.TimelinePanel.prototype = {
if (this._captureTracingSetting && this._captureTracingSetting.get())
this._addModeView(new WebInspector.TimelineTracingView(this, this._tracingModel, this._model));
- this._timelineView().setFrameModel(isFrameMode ? this._frameModel() : null);
+ if (this._lazyTimelineView)
+ this._lazyTimelineView.setFrameModel(isFrameMode ? this._frameModel() : null);
alph 2014/07/03 10:16:44 I'm wondering how it's going to setFrameModel when
loislo 2014/07/03 11:37:32 If we selected a mode where TimelineView needs to
+
this._overviewPane.setOverviewControls(this._overviewControls);
this.doResize();
this._updateSelectedRangeStats();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698