DevTools: Timeline: do not force lazyTimelineView to be created.

Source/devtools/front_end/timeline/TimelinePanel.js

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  * Copyright (C) 2012 Intel Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 310 matching lines @@
             this._currentViews[i].removeEventListener(WebInspector.SplitView.Events.SidebarSizeChanged, this._sidebarResized, this);
             this._currentViews[i].dispose();
         }
         this._currentViews = [];
         this._stackView.detachChildViews();
     },
 
     _createRecordingOptions: function()
     {
         var topPaneSidebarElement = this._topPane.sidebarElement();
-
         this._captureStacksSetting = WebInspector.settings.createSetting("timelineCaptureStacks", true);
         topPaneSidebarElement.appendChild(WebInspector.SettingsUI.createSettingCheckbox(WebInspector.UIString("Capture stacks"),
                                           this._captureStacksSetting, true, undefined,
                                           WebInspector.UIString("Capture JavaScript stack on every timeline event")));
 
         this._captureMemorySetting = WebInspector.settings.createSetting("timelineCaptureMemory", false);
         topPaneSidebarElement.appendChild(WebInspector.SettingsUI.createSettingCheckbox(WebInspector.UIString("Capture memory"),
                                           this._captureMemorySetting, true, undefined,
                                           WebInspector.UIString("Capture memory information on every timeline event")));
         this._captureMemorySetting.addChangeListener(this._onModeChanged, this);
@@ skipping 307 matching lines @@
 
         if (this._capturePowerSetting && this._capturePowerSetting.get()) {
             if (!isFrameMode)  // Frame mode skews time, don't render aux overviews.
                 this._overviewControls.push(new WebInspector.TimelinePowerOverview(this._model));
             this._addModeView(new WebInspector.TimelinePowerGraph(this, this._model));
         }
 
         if (this._captureTracingSetting && this._captureTracingSetting.get())
             this._addModeView(new WebInspector.TimelineTracingView(this, this._tracingModel, this._model));
 
-        this._timelineView().setFrameModel(isFrameMode ? this._frameModel() : null);
+        if (this._lazyTimelineView)
+            this._lazyTimelineView.setFrameModel(isFrameMode ? this._frameModel() : null);

[alph, 2014/07/03 10:16:44]

I'm wondering how it's going to setFrameModel when the lazy view is finally
created?

[loislo, 2014/07/03 11:37:32]

If we selected a mode where TimelineView needs to be created then we create or
reuse it in the line 640 of the file.

+
         this._overviewPane.setOverviewControls(this._overviewControls);
         this.doResize();
         this._updateSelectedRangeStats();
 
         this._stackView.show(this._searchableView.element);
     },
 
     /**
      * @param {boolean} userInitiated
      */
@@ skipping 775 matching lines @@
      * @param {!WebInspector.TimelineModel.Record} record
      * @return {boolean}
      */
     accept: function(record)
     {
         return !this._regex || this._uiUtils.testContentMatching(record, this._regex);
     },
 
     __proto__: WebInspector.TimelineModel.Filter.prototype
 }