Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 364153002: DevTools: Timeline: do not force lazyTimelineView to be created. (Closed)

Created:
6 years, 5 months ago by loislo
Modified:
6 years, 5 months ago
Reviewers:
alph, yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Timeline: do not force lazyTimelineView to be created. Otherwise it is creating right from the constructor. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177479

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M Source/devtools/front_end/timeline/TimelinePanel.js View 2 chunks +3 lines, -2 lines 2 comments Download

Messages

Total messages: 8 (0 generated)
loislo
6 years, 5 months ago (2014-07-03 07:02:45 UTC) #1
alph
https://codereview.chromium.org/364153002/diff/1/Source/devtools/front_end/timeline/TimelinePanel.js File Source/devtools/front_end/timeline/TimelinePanel.js (right): https://codereview.chromium.org/364153002/diff/1/Source/devtools/front_end/timeline/TimelinePanel.js#newcode659 Source/devtools/front_end/timeline/TimelinePanel.js:659: this._lazyTimelineView.setFrameModel(isFrameMode ? this._frameModel() : null); I'm wondering how it's ...
6 years, 5 months ago (2014-07-03 10:16:44 UTC) #2
loislo
https://codereview.chromium.org/364153002/diff/1/Source/devtools/front_end/timeline/TimelinePanel.js File Source/devtools/front_end/timeline/TimelinePanel.js (right): https://codereview.chromium.org/364153002/diff/1/Source/devtools/front_end/timeline/TimelinePanel.js#newcode659 Source/devtools/front_end/timeline/TimelinePanel.js:659: this._lazyTimelineView.setFrameModel(isFrameMode ? this._frameModel() : null); On 2014/07/03 10:16:44, alph ...
6 years, 5 months ago (2014-07-03 11:37:32 UTC) #3
alph
lgtm
6 years, 5 months ago (2014-07-03 11:42:05 UTC) #4
loislo
The CQ bit was checked by loislo@chromium.org
6 years, 5 months ago (2014-07-03 12:49:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/loislo@chromium.org/364153002/1
6 years, 5 months ago (2014-07-03 12:50:14 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_compile_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-03 14:09:22 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-03 14:23:01 UTC) #8
Message was sent while issue was closed. 
Change committed as 177479

Powered by Google App Engine
This is Rietveld 408576698