Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Unified Diff: content/browser/media/capture/web_contents_capture_util.cc

Issue 364123002: [Cross-Site Isolation] Migrate entire MediaStream verticals to be per-RenderFrame. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: It's random enough. + REBASE Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/media/capture/web_contents_capture_util.cc
diff --git a/content/browser/media/capture/web_contents_capture_util.cc b/content/browser/media/capture/web_contents_capture_util.cc
index 57b636a896007eef98e543e8a91a24d314948a6c..e1c5d52351f83bfe592ab5accb10c6fd88dd65c6 100644
--- a/content/browser/media/capture/web_contents_capture_util.cc
+++ b/content/browser/media/capture/web_contents_capture_util.cc
@@ -9,40 +9,24 @@
#include "base/strings/string_piece.h"
#include "base/strings/string_util.h"
-namespace {
-
-const char kVirtualDeviceScheme[] = "virtual-media-stream://";
-
-} // namespace
-
namespace content {
-std::string WebContentsCaptureUtil::AppendWebContentsDeviceScheme(
- const std::string& device_id) {
- return kVirtualDeviceScheme + device_id;
-}
-
-std::string WebContentsCaptureUtil::StripWebContentsDeviceScheme(
- const std::string& device_id) {
- return (IsWebContentsDeviceId(device_id) ?
- device_id.substr(arraysize(kVirtualDeviceScheme) - 1) :
- device_id);
-}
-
bool WebContentsCaptureUtil::IsWebContentsDeviceId(
const std::string& device_id) {
- return StartsWithASCII(device_id, kVirtualDeviceScheme, true);
+ int ignored;
+ return ExtractTabCaptureTarget(device_id, &ignored, &ignored);
}
bool WebContentsCaptureUtil::ExtractTabCaptureTarget(
const std::string& device_id_param,
int* render_process_id,
- int* render_view_id) {
- if (!IsWebContentsDeviceId(device_id_param))
+ int* main_render_frame_id) {
+ static const char kDeviceScheme[] = "web-contents-media-stream://";
+ if (!StartsWithASCII(device_id_param, kDeviceScheme, true))
return false;
const std::string device_id = device_id_param.substr(
- arraysize(kVirtualDeviceScheme) - 1);
+ arraysize(kDeviceScheme) - 1);
const size_t sep_pos = device_id.find(':');
if (sep_pos == std::string::npos)
@@ -53,7 +37,7 @@ bool WebContentsCaptureUtil::ExtractTabCaptureTarget(
device_id.length() - sep_pos - 1);
return (base::StringToInt(component1, render_process_id) &&
- base::StringToInt(component2, render_view_id));
+ base::StringToInt(component2, main_render_frame_id));
}
} // namespace content
« no previous file with comments | « content/browser/media/capture/web_contents_capture_util.h ('k') | content/browser/media/capture/web_contents_tracker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698