[Cross-Site Isolation] Migrate entire MediaStream verticals to be per-RenderFrame.

content/public/browser/speech_recognition_session_context.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_SPEECH_RECOGNITION_SESSION_CONTEXT_H_
 #define CONTENT_PUBLIC_BROWSER_SPEECH_RECOGNITION_SESSION_CONTEXT_H_
 
 #include <string>
 
 #include "content/common/content_export.h"
 #include "content/public/common/media_stream_request.h"
 #include "ui/gfx/rect.h"
 
 namespace content {
 
 // The context information required by clients of the SpeechRecognitionManager
 // and its delegates for mapping the recognition session to other browser
 // elements involved with it (e.g., the page element that requested the
 // recognition). The manager keeps this struct attached to the recognition
 // session during all the session lifetime, making its contents available to
 // clients (In this regard, see SpeechRecognitionManager::GetSessionContext and
 // SpeechRecognitionManager::LookupSessionByContext methods).
 struct CONTENT_EXPORT SpeechRecognitionSessionContext {
   SpeechRecognitionSessionContext();
   ~SpeechRecognitionSessionContext();
 
   int render_process_id;
   int render_view_id;
+  int render_frame_id;

[jam, 2014/07/15 02:04:08]

it's redundant to have render_view_id and render_frame_id, since
RenderFrameHost::FromID(render_process_id, render_frame_id)->GetRenderViewHost()
provides the RVH. it's problematic to have both RF and RV ID since it could
result in an inconsistent state (where the RenderFrameHost's WC isn't the same
as the RenderViewHost's WC).

can you remove render_view_id and call
RenderFrameHost::FromID(render_process_id, render_frame_id)->GetRenderViewHost()
everywhere that we temporarily need the render view id for now?

[miu, 2014/07/15 20:37:55]

I can't do the conversion in this CL.  It's not as simple as calling
RenderFrameHost::FromID() because the render_view_id is used in a lot of the 
"control" methods that run on the IO thread.  There's a lot of work, and it
could easily be its own 200+ LOC change.

I think this is safe right now, since the Speech Recognition implementation is
mostly unchanged (i.e., RenderView based).  The only reason I added
render_frame_id is so the code could make use of
MediaStreamManager::MakeMediaAccessRequest().  Actually, the Speech Recognition
impl isn't really using MSManager like all the other media code.  It's just
trying to utilize the media permissions UI to request access from the user, then
doing it's own thing separately.  There's a TODO comment in
MediaStreamManager::MakeMediaAccessRequest that hints at a design problem with
this.

 
   // Browser plugin guest's render view id, if this context represents a speech
   // recognition request from an embedder on behalf of the guest. This is used
   // for input tag where speech bubble is to be shown.
   //
   // TODO(lazyboy): Right now showing bubble from guest does not work, we fall
   // back to embedder instead, fix this and use
   // embedder_render_process_id/embedder_render_view_id similar to Web Speech
   // API below.
   int guest_render_view_id;
@@ skipping 14 matching lines @@
   // The label for the permission request, it is used for request abortion.
   std::string label;
 
   // A list of devices being used by the recognition session.
   MediaStreamDevices devices;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_SPEECH_RECOGNITION_SESSION_CONTEXT_H_