Use the HeapObjectIterator to scan-on-scavenge map pages.

Use the HeapObjectIterator to scan-on-scavenge map pages.

Deserializing the partial snapshot may prematurely stop using a map page, adding a free-space filler at the end. Scan-on-scavenge of map-space did not expect anything but maps, and would interpret the uninitialized memory as pointers. Using the heap iterator we can skip over free space and only visit maps.

BUG=390732
LOG=y
R=hpayer@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=22208

[Toon Verwaest, 2014-07-03 16:43:37]

PTAL

[Hannes Payer (out of office), 2014-07-03 16:46:08]

lgtm

[Toon Verwaest, 2014-07-03 16:55:40]

Committed patchset #1 manually as r22208 (presubmit successful).

[caitp (gmail), 2014-07-04 08:12:55]

On 2014/07/03 16:55:40, Toon Verwaest wrote:
> Committed patchset #1 manually as r22208 (presubmit successful).

Not positive, but this CL may have been responsible for -Wunused-function errors
in bleeding_edge which I'm noticing this morning.

> ../src/store-buffer.cc:407:23: error: unused function 'MapStartAlign'
[-Werror,-Wunused-function]
> static inline Address MapStartAlign(Address addr) {
>                   ^
> ../src/store-buffer.cc:414:23: error: unused function 'MapEndAlign'
[-Werror,-Wunused-function]
> static inline Address MapEndAlign(Address addr) {
>                      ^