Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Unified Diff: cc/trees/layer_tree_host_impl.cc

Issue 364063005: Histogram to track missing and incomplete tiles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address review comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/trees/layer_tree_host_impl.cc
diff --git a/cc/trees/layer_tree_host_impl.cc b/cc/trees/layer_tree_host_impl.cc
index de1e8ffcacd26e2befe65d392552ba699e0a7b75..3c15ebad53fc474b12bc1ff1458c8d83d9c66ba6 100644
--- a/cc/trees/layer_tree_host_impl.cc
+++ b/cc/trees/layer_tree_host_impl.cc
@@ -778,6 +778,9 @@ DrawResult LayerTreeHostImpl::CalculateRenderPasses(
int layers_drawn = 0;
+ int num_missing_tiles = 0;
+ int num_incomplete_tiles = 0;
+
const DrawMode draw_mode = GetDrawMode(output_surface_.get());
LayerIteratorType end =
@@ -856,6 +859,7 @@ DrawResult LayerTreeHostImpl::CalculateRenderPasses(
append_quads_data.approximated_visible_content_area);
if (append_quads_data.num_missing_tiles) {
+ num_missing_tiles += append_quads_data.num_missing_tiles;
bool layer_has_animating_transform =
it->screen_space_transform_is_animating() ||
it->draw_transform_is_animating();
@@ -863,7 +867,9 @@ DrawResult LayerTreeHostImpl::CalculateRenderPasses(
draw_result = DRAW_ABORTED_CHECKERBOARD_ANIMATIONS;
}
- if (append_quads_data.had_incomplete_tile) {
+ if (append_quads_data.num_incomplete_tiles ||
+ append_quads_data.num_missing_tiles) {
+ num_incomplete_tiles += append_quads_data.num_incomplete_tiles;
danakj 2014/07/07 22:07:40 maybe these += don't really fit inside these if bl
frame->contains_incomplete_tile = true;
if (active_tree()->RequiresHighResToDraw())
draw_result = DRAW_ABORTED_MISSING_HIGH_RES_CONTENT;
@@ -914,6 +920,15 @@ DrawResult LayerTreeHostImpl::CalculateRenderPasses(
// If we're making a frame to draw, it better have at least one render pass.
DCHECK(!frame->render_passes.empty());
+ if (IsCurrentlyScrolling()) {
+ UMA_HISTOGRAM_COUNTS_100(
+ "Compositing.RenderPass.AppendQuadData.NumMissingTiles",
+ num_missing_tiles);
+ UMA_HISTOGRAM_COUNTS_100(
+ "Compositing.RenderPass.AppendQuadData.NumIncompleteTiles",
+ num_incomplete_tiles);
+ }
+
// Should only have one render pass in resourceless software mode.
if (output_surface_->ForcedDrawToSoftwareDevice())
DCHECK_EQ(1u, frame->render_passes.size());

Powered by Google App Engine
This is Rietveld 408576698