Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: cc/trees/layer_tree_host_impl.cc

Issue 364063005: Histogram to track missing and incomplete tiles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rm confusing missing_tiles++ Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/layers/picture_layer_impl.cc ('k') | cc/trees/layer_tree_host_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/layer_tree_host_impl.cc
diff --git a/cc/trees/layer_tree_host_impl.cc b/cc/trees/layer_tree_host_impl.cc
index 3b971912eb5e767ac1a2d745ded9fee18adfab61..37cbf851ae85276a0965dd25358e9f2120e6fd4d 100644
--- a/cc/trees/layer_tree_host_impl.cc
+++ b/cc/trees/layer_tree_host_impl.cc
@@ -800,6 +800,9 @@ DrawResult LayerTreeHostImpl::CalculateRenderPasses(
const DrawMode draw_mode = GetDrawMode();
+ int num_missing_tiles = 0;
+ int num_incomplete_tiles = 0;
+
LayerIteratorType end =
LayerIteratorType::End(frame->render_surface_layer_list);
for (LayerIteratorType it =
@@ -875,6 +878,9 @@ DrawResult LayerTreeHostImpl::CalculateRenderPasses(
rendering_stats_instrumentation_->AddApproximatedVisibleContentArea(
append_quads_data.approximated_visible_content_area);
+ num_missing_tiles += append_quads_data.num_missing_tiles;
+ num_incomplete_tiles += append_quads_data.num_incomplete_tiles;
+
if (append_quads_data.num_missing_tiles) {
bool layer_has_animating_transform =
it->screen_space_transform_is_animating() ||
@@ -883,7 +889,8 @@ DrawResult LayerTreeHostImpl::CalculateRenderPasses(
draw_result = DRAW_ABORTED_CHECKERBOARD_ANIMATIONS;
}
- if (append_quads_data.had_incomplete_tile) {
+ if (append_quads_data.num_incomplete_tiles ||
+ append_quads_data.num_missing_tiles) {
frame->contains_incomplete_tile = true;
if (active_tree()->RequiresHighResToDraw())
draw_result = DRAW_ABORTED_MISSING_HIGH_RES_CONTENT;
@@ -934,6 +941,15 @@ DrawResult LayerTreeHostImpl::CalculateRenderPasses(
// If we're making a frame to draw, it better have at least one render pass.
DCHECK(!frame->render_passes.empty());
+ if (IsCurrentlyScrolling()) {
+ UMA_HISTOGRAM_COUNTS_100(
+ "Compositing.RenderPass.AppendQuadData.NumMissingTiles",
+ num_missing_tiles);
+ UMA_HISTOGRAM_COUNTS_100(
+ "Compositing.RenderPass.AppendQuadData.NumIncompleteTiles",
+ num_incomplete_tiles);
+ }
+
// Should only have one render pass in resourceless software mode.
DCHECK(draw_mode != DRAW_MODE_RESOURCELESS_SOFTWARE ||
frame->render_passes.size() == 1u)
« no previous file with comments | « cc/layers/picture_layer_impl.cc ('k') | cc/trees/layer_tree_host_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698