Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 364053004: Translate: Bug fix: Don't show the bubble when the window is inactive (Closed)

Created:
6 years, 5 months ago by hajimehoshi
Modified:
6 years, 5 months ago
Reviewers:
msw
CC:
chromium-reviews, tfarina, sky
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Translate: Bug fix: Don't show the bubble when the window is inactive Now there is a but that the bubble is shown even though the window is minimized. This CL fixes this bug. BUG=389014 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281682

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/ui/views/frame/browser_view.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hajimehoshi
PTAL
6 years, 5 months ago (2014-07-03 04:10:12 UTC) #1
msw
lgtm
6 years, 5 months ago (2014-07-03 05:07:24 UTC) #2
hajimehoshi
The CQ bit was checked by hajimehoshi@chromium.org
6 years, 5 months ago (2014-07-08 05:25:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/364053004/1
6 years, 5 months ago (2014-07-08 05:26:31 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_rel_device on tryserver.chromium ...
6 years, 5 months ago (2014-07-08 07:10:49 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-08 07:15:08 UTC) #6
Message was sent while issue was closed.
Change committed as 281682

Powered by Google App Engine
This is Rietveld 408576698