Source/web/WebMediaPlayerClientImpl.cpp - Issue 364033003: Eliminate MediaPlayer abstraction(network state)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebMediaPlayerClientImpl.cpp

Issue 364033003: Eliminate MediaPlayer abstraction(network state) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Modified the approach as suggested Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/WebMediaPlayerClientImpl.cpp

diff --git a/Source/web/WebMediaPlayerClientImpl.cpp b/Source/web/WebMediaPlayerClientImpl.cpp

index a5a4f1f323d7dcae0ca19181c8ab0d30a96a7fc3..d6c86149a983df26be0d86e9de9b6d69f41fd29d 100644

--- a/Source/web/WebMediaPlayerClientImpl.cpp

+++ b/Source/web/WebMediaPlayerClientImpl.cpp

@@ -258,13 +258,6 @@ void WebMediaPlayerClientImpl::setPoster(const KURL& poster)

m_webMediaPlayer->setPoster(WebURL(poster));

}

-MediaPlayer::NetworkState WebMediaPlayerClientImpl::networkState() const

- if (m_webMediaPlayer)

- return static_cast<MediaPlayer::NetworkState>(m_webMediaPlayer->networkState());

- return MediaPlayer::Empty;

void WebMediaPlayerClientImpl::paint(GraphicsContext* context, const IntRect& rect)

{

// Normally GraphicsContext operations do nothing when painting is disabled.