Source/platform/graphics/media/MediaPlayer.h - Issue 364033003: Eliminate MediaPlayer abstraction(network state)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/graphics/media/MediaPlayer.h

Issue 364033003: Eliminate MediaPlayer abstraction(network state) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Modified the approach as suggested Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/graphics/media/MediaPlayer.h

diff --git a/Source/platform/graphics/media/MediaPlayer.h b/Source/platform/graphics/media/MediaPlayer.h

index ea5db1cb9cdb1e21acf6df2ab180f094db129cf6..76c8065b74e01a4c38b84de07e67badc055a97ec 100644

--- a/Source/platform/graphics/media/MediaPlayer.h

+++ b/Source/platform/graphics/media/MediaPlayer.h

@@ -122,9 +122,6 @@ public:

virtual void setPoster(const KURL&) = 0;

- enum NetworkState { Empty, Idle, Loading, Loaded, FormatError, NetworkError, DecodeError };

- virtual NetworkState networkState() const = 0;

virtual void paint(GraphicsContext*, const IntRect&) = 0;

virtual bool copyVideoTextureToPlatformTexture(blink::WebGraphicsContext3D*, Platform3DObject, GC3Dint, GC3Denum, GC3Denum, bool, bool) = 0;