Source/core/html/HTMLMediaElement.h - Issue 364033003: Eliminate MediaPlayer abstraction(network state)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLMediaElement.h

Issue 364033003: Eliminate MediaPlayer abstraction(network state) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Modified the approach as suggested Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLMediaElement.h

diff --git a/Source/core/html/HTMLMediaElement.h b/Source/core/html/HTMLMediaElement.h

index 034fac9ef852bbc3dc2c7ef1a53f9deb870aecc2..cf2771529f3c1b8053318ce1027135a0a9e8378f 100644

--- a/Source/core/html/HTMLMediaElement.h

+++ b/Source/core/html/HTMLMediaElement.h

@@ -350,7 +350,7 @@ private:

virtual void updateDisplayState() { }

void setReadyState(ReadyState);

- void setNetworkState(MediaPlayer::NetworkState);

+ void setNetworkState(blink::WebMediaPlayer::NetworkState);

virtual void mediaPlayerNetworkStateChanged() OVERRIDE FINAL;

virtual void mediaPlayerReadyStateChanged() OVERRIDE FINAL;

@@ -401,7 +401,7 @@ private:

KURL selectNextSourceChild(ContentType*, String* keySystem, InvalidURLAction);

- void mediaLoadingFailed(MediaPlayer::NetworkState);

+ void mediaLoadingFailed(blink::WebMediaPlayer::NetworkState);

// deferred loading (preload=none)

bool loadIsDeferred() const;