Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 364033002: Gate CrashHandler with SK_CRASH_HANDLER. (Closed)

Created:
6 years, 5 months ago by mtklein_C
Modified:
6 years, 5 months ago
Reviewers:
bsalomon, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Gate CrashHandler with SK_CRASH_HANDLER. BUG=skia: Committed: https://skia.googlesource.com/skia/+/0e3fac215d0ee2e2efaca69b7d53f636f4fe5ba7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -164 lines) Patch
M tools/CrashHandler.h View 1 chunk +5 lines, -3 lines 0 comments Download
M tools/CrashHandler.cpp View 1 chunk +170 lines, -161 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mtklein
6 years, 5 months ago (2014-07-02 20:51:07 UTC) #1
bsalomon
lgtm
6 years, 5 months ago (2014-07-02 20:51:51 UTC) #2
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 5 months ago (2014-07-02 21:15:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/364033002/1
6 years, 5 months ago (2014-07-02 21:15:56 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-02 21:30:50 UTC) #5
Message was sent while issue was closed.
Change committed as 0e3fac215d0ee2e2efaca69b7d53f636f4fe5ba7

Powered by Google App Engine
This is Rietveld 408576698