Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Issue 364003003: Fix default video decoder issue (Closed)

Created:
6 years, 5 months ago by sehr
Modified:
6 years, 5 months ago
Reviewers:
bbudge, David Yen
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

Fix default video decoder issue On Android there is no software fallback for the video decoder. Disable the fallback path and remove the dependencies. BUG= https://code.google.com/p/nativeclient/issues/detail?id=3032 R=bbudge@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282070

Patch Set 1 #

Patch Set 2 : Remove unrelated change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M content/content_renderer.gypi View 1 chunk +9 lines, -0 lines 0 comments Download
M content/renderer/pepper/pepper_video_decoder_host.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
sehr
The nacl.gyp changes may be unrelated. I'm going to try removing them again. Otherwise, PTAL.
6 years, 5 months ago (2014-07-02 23:06:21 UTC) #1
bbudge
content LGTM
6 years, 5 months ago (2014-07-05 04:42:59 UTC) #2
sehr
The CQ bit was checked by sehr@chromium.org
6 years, 5 months ago (2014-07-07 21:18:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sehr@chromium.org/364003003/20001
6 years, 5 months ago (2014-07-07 21:21:09 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 5 months ago (2014-07-08 01:49:19 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-08 02:19:10 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/90457)
6 years, 5 months ago (2014-07-08 02:19:11 UTC) #7
David Yen
The CQ bit was checked by dyen@chromium.org
6 years, 5 months ago (2014-07-09 16:26:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sehr@chromium.org/364003003/20001
6 years, 5 months ago (2014-07-09 16:28:28 UTC) #9
sehr
6 years, 5 months ago (2014-07-09 17:04:12 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 manually as r282070 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698