Refactored TTS extension code so that the platform-specific TTS...

Refactored TTS extension code so that the platform-specific TTS
implementation code is separate from the extension API code.
That will make it easier to add more functionality that's shared
by all platforms next.

BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62283

[Chaitanya, 2010-10-11 17:29:15]

http://codereview.chromium.org/3640001/diff/1/3
File chrome/browser/extensions/extension_tts_api.h (right):

http://codereview.chromium.org/3640001/diff/1/3#newcode24
chrome/browser/extensions/extension_tts_api.h:24: double rate,
const?

http://codereview.chromium.org/3640001/diff/1/4
File chrome/browser/extensions/extension_tts_api_chromeos.cc (right):

http://codereview.chromium.org/3640001/diff/1/4#newcode47
chrome/browser/extensions/extension_tts_api_chromeos.cc:47: 
ExtensionTtsPlatformImplChromeOs::GetInstance() is not defined:

// static
ExtensionTtsPlatformImplChromeOs*
ExtensionTtsPlatformImplChromeOs::GetInstance() {
  return Singleton<ExtensionTtsPlatformImplChromeOs>::get();
}

http://codereview.chromium.org/3640001/diff/1/6
File chrome/browser/extensions/extension_tts_api_linux.cc (right):

http://codereview.chromium.org/3640001/diff/1/6#newcode43
chrome/browser/extensions/extension_tts_api_linux.cc:43: return
ExtensionTtsPlatformImplLinux::GetInstance();
return Singleton<ExtensionTtsPlatformImplLinux>::get();

[dmazzoni, 2010-10-11 22:58:29]

On Mon, Oct 11, 2010 at 10:29 AM, <chaitanyag@chromium.org> wrote:

> http://codereview.chromium.org/3640001/diff/1/3#newcode24
> chrome/browser/extensions/extension_tts_api.h:24: double rate,
> const?
>

I don't think const is normally used for POD (plain old data) arguments
passed by value.

ExtensionTtsPlatformImplChromeOs::GetInstance() is not defined:
>

Thanks, fixed both of these and submitting to all of the trybots again.

- Dominic

[Chaitanya, 2010-10-12 00:08:01]

lgtm

Thanks, it was a good change.

On Mon, Oct 11, 2010 at 3:51 PM, Dominic Mazzoni <dmazzoni@chromium.org>wrote:

> On Mon, Oct 11, 2010 at 10:29 AM, <chaitanyag@chromium.org> wrote:
>
>> http://codereview.chromium.org/3640001/diff/1/3#newcode24
>> chrome/browser/extensions/extension_tts_api.h:24: double rate,
>> const?
>>
>
> I don't think const is normally used for POD (plain old data) arguments
> passed by value.
>
> ExtensionTtsPlatformImplChromeOs::GetInstance() is not defined:
>>
>
> Thanks, fixed both of these and submitting to all of the trybots again.
>
> - Dominic
>
>