Move chrome.power API from chrome/ to extensions/.

Move chrome.power API from chrome/ to extensions/.

BUG=389348
TBR=sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281220

[Daniel Erat, 2014-07-02 21:36:06]

so many fiddly little files to update... chrome.power.requestKeepAwake works
both under chrome and under app_shell with this change, though, so hopefully i
didn't miss any.

https://codereview.chromium.org/363993003/diff/1/extensions/DEPS
File extensions/DEPS (right):

https://codereview.chromium.org/363993003/diff/1/extensions/DEPS#newcode40
extensions/DEPS:40: "+chrome/test/base/browser_with_test_window_test.h",
let me know if you'd prefer that i try to find some way to remove this
dependency in this change -- presumably the test doesn't actually need a test
window.

https://codereview.chromium.org/363993003/diff/1/extensions/browser/api/power...
File extensions/browser/api/power/power_api_manager.cc (right):

https://codereview.chromium.org/363993003/diff/1/extensions/browser/api/power...
extensions/browser/api/power/power_api_manager.cc:111:
power_save_blocker_.reset();
resetting this when the ExtensionRegistry is being destroyed rather than in
response to NOTIFICATION_APP_TERMINATING seems to work. i think that the
original reason for this was to ensure that the blocker didn't try to interact
with chromeos::PowerManagerClient after the PMC had been destroyed (which
happens pretty late in the shutdown process, i believe).

[miket_OOO, 2014-07-02 22:22:02]

Rubber-stamp OWNER LGTM subject to rockot's approval.

[Ken Rockot(use gerrit already), 2014-07-02 23:32:09]

lgtm

https://codereview.chromium.org/363993003/diff/1/extensions/DEPS
File extensions/DEPS (right):

https://codereview.chromium.org/363993003/diff/1/extensions/DEPS#newcode40
extensions/DEPS:40: "+chrome/test/base/browser_with_test_window_test.h",
On 2014/07/02 21:36:06, Daniel Erat wrote:
> let me know if you'd prefer that i try to find some way to remove this
> dependency in this change -- presumably the test doesn't actually need a test
> window.

Seems OK to me for now.

https://codereview.chromium.org/363993003/diff/1/extensions/browser/api/power...
File extensions/browser/api/power/power_api_manager.h (left):

https://codereview.chromium.org/363993003/diff/1/extensions/browser/api/power...
extensions/browser/api/power/power_api_manager.h:31: public
content::NotificationObserver,
Deleted NotificationObserver is best NotificationObserver!

[Daniel Erat, 2014-07-02 23:48:57]

The CQ bit was checked by derat@chromium.org

[commit-bot: I haz the power, 2014-07-02 23:51:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/derat@chromium.org/363993003/1

[commit-bot: I haz the power, 2014-07-03 02:46:23]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)

[commit-bot: I haz the power, 2014-07-03 02:53:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-03 02:53:33]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)

[Daniel Erat, 2014-07-03 05:25:02]

TBR scott for DEPS change

[Daniel Erat, 2014-07-03 05:25:09]

The CQ bit was checked by derat@chromium.org

[commit-bot: I haz the power, 2014-07-03 05:27:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/derat@chromium.org/363993003/20001

[commit-bot: I haz the power, 2014-07-03 07:54:13]

Change committed as 281220