Index: src/opts/SkBlitRow_opts_SSE4.h |
diff --git a/src/opts/SkBlitRow_opts_SSE4.h b/src/opts/SkBlitRow_opts_SSE4.h |
index c49c392d0acb5015012129f7edee5d2ff743c78f..6c74c900f5336fdeaa84e9830980d924bb49617d 100644 |
--- a/src/opts/SkBlitRow_opts_SSE4.h |
+++ b/src/opts/SkBlitRow_opts_SSE4.h |
@@ -10,12 +10,14 @@ |
#include "SkBlitRow.h" |
-/* Check if we are able to build assembly code, GCC/AT&T syntax. |
- * Had problems with LLVM-GCC 4.2. |
- * MemorySanitizer cannot handle assembly code. |
+/* Check if we are able to build assembly code, GCC/AT&T syntax: |
+ * 1) Clang and GCC are generally OK. OS X's old LLVM-GCC 4.2 can't handle it; |
Nico
2014/07/02 19:05:46
(fwiw, we don't use OS X's llvm-gcc in chrome. May
|
+ * 2) Clang for Windows doesn't support AT&T syntax; |
Reid Kleckner
2014/07/02 19:04:48
This comment isn't true, Clang can probably assemb
Nico
2014/07/02 19:05:46
I think it does – the problem on the bug is just t
|
+ * 3) MemorySanitizer cannot instrument assembly at all. |
*/ |
-#if (defined(__clang__) || (defined(__GNUC__) && !defined(SK_BUILD_FOR_MAC))) \ |
- && !defined(MEMORY_SANITIZER) |
+#if /* 1)*/ (defined(__clang__) || (defined(__GNUC__) && !defined(SK_BUILD_FOR_MAC))) \ |
+ /* 2)*/ && !defined(SK_BUILD_FOR_WIN) \ |
+ /* 3)*/ && !defined(MEMORY_SANITIZER) |
extern "C" void S32A_Opaque_BlitRow32_SSE4_asm(SkPMColor* SK_RESTRICT dst, |
const SkPMColor* SK_RESTRICT src, |
int count, U8CPU alpha); |