Exclude Clang on Windows too. Comment this up a bit.

Exclude Clang on Windows too.  Comment this up a bit.

BUG=391016
Committed: https://skia.googlesource.com/skia/+/3fa56b322acd1fc722124f349d155fc29d8500cc

[Reid Kleckner, 2014-07-02 19:04:48]

lgtm a comment clarification

https://codereview.chromium.org/363983004/diff/1/src/opts/SkBlitRow_opts_SSE4.h
File src/opts/SkBlitRow_opts_SSE4.h (right):

https://codereview.chromium.org/363983004/diff/1/src/opts/SkBlitRow_opts_SSE4...
src/opts/SkBlitRow_opts_SSE4.h:15: *  2) Clang for Windows doesn't support AT&T
syntax;
This comment isn't true, Clang can probably assemble that .s file.  It's just
that gyp isn't asking it to.  Wiring that up isn't high priority, given that
clang for windows is in pretty early days, but eventually we could do it.

[Nico, 2014-07-02 19:05:46]

https://codereview.chromium.org/363983004/diff/1/src/opts/SkBlitRow_opts_SSE4.h
File src/opts/SkBlitRow_opts_SSE4.h (right):

https://codereview.chromium.org/363983004/diff/1/src/opts/SkBlitRow_opts_SSE4...
src/opts/SkBlitRow_opts_SSE4.h:14: *  1) Clang and GCC are generally OK.  OS X's
old LLVM-GCC 4.2 can't handle it;
(fwiw, we don't use OS X's llvm-gcc in chrome. Maybe you care about it for skia
for other reasons though.)

https://codereview.chromium.org/363983004/diff/1/src/opts/SkBlitRow_opts_SSE4...
src/opts/SkBlitRow_opts_SSE4.h:15: *  2) Clang for Windows doesn't support AT&T
syntax;
I think it does – the problem on the bug is just that the .S file doesn't get
compiled on Windows, and maybe gyp doesn't build .S files on Windows. But I
think clang/win does support both syntaxes:

D:\src\hack\watdbg>..\..\llvm-ninja\bin\clang -c test.cc

D:\src\hack\watdbg>type test.cc
int main() {
      int a=10, b;
        asm ("movl %1, %%eax; movl %%eax, %0;"
             :"=r"(b)        /* output */
             :"r"(a)         /* input */
             :"%eax"         /* clobbered register */
             );

}

[Nico, 2014-07-02 19:06:38]

On 2014/07/02 19:04:48, Reid Kleckner wrote:
> lgtm a comment clarification
> 
>
https://codereview.chromium.org/363983004/diff/1/src/opts/SkBlitRow_opts_SSE4.h
> File src/opts/SkBlitRow_opts_SSE4.h (right):
> 
>
https://codereview.chromium.org/363983004/diff/1/src/opts/SkBlitRow_opts_SSE4...
> src/opts/SkBlitRow_opts_SSE4.h:15: *  2) Clang for Windows doesn't support
AT&T
> syntax;
> This comment isn't true, Clang can probably assemble that .s file.  It's just
> that gyp isn't asking it to.  Wiring that up isn't high priority, given that
> clang for windows is in pretty early days, but eventually we could do it.

(I think as long as cl.exe is around, we want to keep the clang/win build as
close as possible to the cl.exe/win build)

[mtklein, 2014-07-02 19:08:52]

So, how's this then?

[Nico, 2014-07-02 19:11:40]

lgtm, thanks!

[mtklein, 2014-07-02 19:11:59]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-07-02 19:13:05]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/363983004/20001

[commit-bot: I haz the power, 2014-07-02 19:13:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-02 19:13:07]

No LGTM from a valid reviewer yet. Please ask for an LGTM from a
full Skia committer from
https://skia.googlesource.com/skia/+/master/CQ_COMMITTERS

[mtklein, 2014-07-02 19:14:42]

lgtm

[commit-bot: I haz the power, 2014-07-02 19:38:42]

Change committed as 3fa56b322acd1fc722124f349d155fc29d8500cc