Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 363973002: DevTools: bake generic css files into the concatenated one. (Closed)

Created:
6 years, 5 months ago by pfeldman
Modified:
6 years, 5 months ago
Reviewers:
vsevik, apavlov, lushnikov
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: bake generic css files into the concatenated one. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177472

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -83 lines) Patch
M Source/devtools/devtools.gypi View 3 chunks +4 lines, -5 lines 0 comments Download
D Source/devtools/front_end/breadcrumbList.css View 1 chunk +0 lines, -66 lines 0 comments Download
M Source/devtools/front_end/common/utilities.js View 1 chunk +1 line, -2 lines 0 comments Download
M Source/devtools/front_end/console/ConsoleView.js View 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/elements/ElementsPanel.js View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/devtools/front_end/elementsPanel.css View 1 chunk +40 lines, -0 lines 0 comments Download
M Source/devtools/front_end/inspector.html View 1 chunk +4 lines, -1 line 0 comments Download
M Source/devtools/front_end/network/NetworkPanel.js View 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/sources/SourcesPanel.js View 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/toolbox/ResponsiveDesignView.js View 1 chunk +1 line, -1 line 1 comment Download
M Source/devtools/front_end/ui/SidebarPane.js View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/devtools/front_end/ui/SplitView.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
pfeldman
6 years, 5 months ago (2014-07-02 17:04:39 UTC) #1
lushnikov
lgtm https://codereview.chromium.org/363973002/diff/20001/Source/devtools/front_end/toolbox/ResponsiveDesignView.js File Source/devtools/front_end/toolbox/ResponsiveDesignView.js (right): https://codereview.chromium.org/363973002/diff/20001/Source/devtools/front_end/toolbox/ResponsiveDesignView.js#newcode18 Source/devtools/front_end/toolbox/ResponsiveDesignView.js:18: this._responsiveDesignContainer.registerRequiredCSS("responsiveDesignView.css"); What difference does this change make?
6 years, 5 months ago (2014-07-03 08:09:53 UTC) #2
pfeldman
The CQ bit was checked by pfeldman@chromium.org
6 years, 5 months ago (2014-07-03 11:19:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/363973002/20001
6 years, 5 months ago (2014-07-03 11:20:07 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-03 12:26:24 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-03 12:57:23 UTC) #6
Message was sent while issue was closed.
Change committed as 177472

Powered by Google App Engine
This is Rietveld 408576698