Source/modules/mediasource/SourceBufferList.cpp - Issue 363953002: Oilpan: have the media element safely close its MediaSource.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/mediasource/SourceBufferList.cpp

Issue 363953002: Oilpan: have the media element safely close its MediaSource. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Tweak assert availability + no need for extra finalization of SourceBuffer Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/mediasource/SourceBufferList.cpp

diff --git a/Source/modules/mediasource/SourceBufferList.cpp b/Source/modules/mediasource/SourceBufferList.cpp

index d79c7f6afae48bc59de1ba784237a02df611e3e5..02499dec97da3112b736bd1d70c64f0d8dcb2dbf 100644

--- a/Source/modules/mediasource/SourceBufferList.cpp

+++ b/Source/modules/mediasource/SourceBufferList.cpp

@@ -46,7 +46,9 @@ SourceBufferList::SourceBufferList(ExecutionContext* context, GenericEventQueue*

SourceBufferList::~SourceBufferList()

{

+#if !ENABLE(OILPAN)

ASSERT(m_list.isEmpty());

+#endif

}

void SourceBufferList::add(SourceBuffer* buffer)

« Source/modules/mediasource/MediaSource.cpp ('K') | « Source/modules/mediasource/SourceBuffer.cpp ('k') | no next file » | no next file with comments »