Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 363933002: setConfig is deprecated, use setInfo or allocPixels instead. (Closed)

Created:
6 years, 5 months ago by reed1
Modified:
6 years, 5 months ago
CC:
ben+ash_chromium.org, chrome-apps-syd-reviews_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, extensions-reviews_chromium.org, jam, jbauman+watch_chromium.org, jochen+watch_chromium.org, kalyank, miu+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, penghuang+watch_chromium.org, piman+watch_chromium.org, sadrul, sievers+watch_chromium.org, stevenjb+watch_chromium.org, James Su, tfarina, yukishiino+watch_chromium.org, yusukes+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

setConfig is deprecated, use setInfo or allocPixels instead. kPNColor_SkColorType is now kN32_SkColorType TBR= BUG=skia:2706 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281044

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -74 lines) Patch
M ash/desktop_background/desktop_background_controller_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ash/desktop_background/wallpaper_resizer_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ash/shell/app_list.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ash/shell/window_watcher.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ash/system/chromeos/network/network_icon.cc View 1 chunk +1 line, -2 lines 0 comments Download
M athena/content/content_app_model_builder.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M athena/test/test_app_model_builder.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/history_menu_bridge_unittest.mm View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/table_row_nsimage_cache_unittest.mm View 1 chunk +1 line, -2 lines 0 comments Download
M components/search_provider_logos/logo_tracker_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_browsertest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M content/shell/renderer/test_runner/TestPlugin.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M extensions/browser/extension_icon_image_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M skia/config/SkUserConfig.h View 1 chunk +0 lines, -8 lines 0 comments Download
M skia/ext/bitmap_platform_device_cairo.cc View 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/bitmap_platform_device_skia.cc View 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/bitmap_platform_device_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/pixel_ref_utils_unittest.cc View 1 chunk +1 line, -5 lines 0 comments Download
M skia/ext/skia_utils_ios.mm View 1 chunk +1 line, -7 lines 0 comments Download
M skia/ext/vector_platform_device_emf_win.h View 1 chunk +0 lines, -5 lines 0 comments Download
M skia/ext/vector_platform_device_emf_win.cc View 1 chunk +1 line, -10 lines 0 comments Download
M ui/app_list/cocoa/apps_grid_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/cocoa/notification_controller_unittest.mm View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
reed1
6 years, 5 months ago (2014-07-02 12:53:15 UTC) #1
reed1
need OWNERS review for refactoring change
6 years, 5 months ago (2014-07-02 13:03:28 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 5 months ago (2014-07-02 13:04:48 UTC) #3
f(malita)
lgtm
6 years, 5 months ago (2014-07-02 13:06:24 UTC) #4
reed1
The CQ bit was checked by reed@google.com
6 years, 5 months ago (2014-07-02 13:07:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/363933002/1
6 years, 5 months ago (2014-07-02 13:08:16 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-02 15:04:04 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-02 15:06:30 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/77596)
6 years, 5 months ago (2014-07-02 15:06:31 UTC) #9
reed1
The CQ bit was checked by reed@google.com
6 years, 5 months ago (2014-07-02 15:44:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/363933002/1
6 years, 5 months ago (2014-07-02 15:44:35 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-02 15:56:37 UTC) #12
Message was sent while issue was closed. 
Change committed as 281044

Powered by Google App Engine
This is Rietveld 408576698