Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 363893003: Stack traces exposed to Javascript should omit extensions. (Closed)

Created:
6 years, 5 months ago by Yang
Modified:
6 years, 5 months ago
Reviewers:
marja
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Stack traces exposed to Javascript should omit extensions. R=marja@chromium.org BUG=v8:311 LOG=Y Committed: https://code.google.com/p/v8/source/detail?r=22162

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -54 lines) Patch
M src/debug.cc View 6 chunks +7 lines, -6 lines 0 comments Download
M src/isolate.cc View 1 3 chunks +45 lines, -46 lines 0 comments Download
M src/objects.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/objects-inl.h View 2 chunks +8 lines, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 chunk +27 lines, -0 lines 0 comments Download
M test/mjsunit/stack-traces-overflow.js View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 5 months ago (2014-07-02 09:50:31 UTC) #1
marja
lgtm
6 years, 5 months ago (2014-07-02 11:45:44 UTC) #2
Yang
6 years, 5 months ago (2014-07-02 13:36:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r22162 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698