Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 363893002: Revert of Reduces dependency from AutocompleteMatch to Profile. (Closed)

Created:
6 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 5 months ago
CC:
chromium-reviews, tfarina, James Su
Project:
chromium
Visibility:
Public.

Description

Revert of Reduces dependency from AutocompleteMatch to Profile. (https://codereview.chromium.org/354773002/) Reason for revert: AutocompleteProviderTest.GetDestinationURL crashes on dbg bots Original issue's description: > Reduces dependency from AutocompleteMatch to Profile. > > BUG=388510 > R=hashimoto@chromium.org, blundell@chromium.org, pkasting@chromium.org > TBR=dtrainor@chromium.org > TEST=compile > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280955 TBR=hashimoto@chromium.org,blundell@chromium.org,pkasting@chromium.org,dtrainor@chromium.org,mukai@chromium.org NOTREECHECKS=true NOTRY=true BUG=388510 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280983

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -154 lines) Patch
M chrome/browser/android/omnibox/autocomplete_controller_android.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_classifier_factory.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_controller.h View 3 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_controller.cc View 11 chunks +11 lines, -14 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_match.h View 5 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_match.cc View 4 chunks +23 lines, -25 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_provider_unittest.cc View 4 chunks +4 lines, -8 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_result.h View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_result.cc View 3 chunks +7 lines, -9 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_result_unittest.cc View 16 chunks +18 lines, -18 lines 0 comments Download
M chrome/browser/autocomplete/base_search_provider.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/autocomplete/history_url_provider_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/autocomplete/search_provider_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/autocomplete/shortcuts_backend.cc View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/autocomplete/shortcuts_provider.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/ui/app_list/search/omnibox_provider.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/omnibox/alternate_nav_infobar_delegate.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/omnibox/omnibox_controller.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/ui/omnibox/omnibox_edit_model.cc View 3 chunks +3 lines, -9 lines 0 comments Download
M chrome/browser/ui/omnibox/omnibox_navigation_observer.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_popup_model.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/frame/test_with_browser_view.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/ui/webui/omnibox/omnibox_ui_handler.cc View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/ui/webui/options/home_page_overlay_handler.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/startup_pages_handler.cc View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
Created Revert of Reduces dependency from AutocompleteMatch to Profile.
6 years, 5 months ago (2014-07-02 09:13:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/363893002/1
6 years, 5 months ago (2014-07-02 09:14:47 UTC) #2
commit-bot: I haz the power
6 years, 5 months ago (2014-07-02 09:16:02 UTC) #3
Message was sent while issue was closed. 
Change committed as 280983

Powered by Google App Engine
This is Rietveld 408576698