Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 363873002: Gallery.app: Add buttons to the cropping mode to specifying the aspect ratio. (Closed)

Created:
6 years, 5 months ago by hirono
Modified:
6 years, 5 months ago
Reviewers:
mtomasz
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Gallery.app: Add buttons to the cropping mode to specifying the aspect ratio. BUG=342176 TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281170

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -3 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 chunk +21 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M ui/file_manager/gallery/css/gallery.css View 2 chunks +26 lines, -1 line 0 comments Download
M ui/file_manager/gallery/js/image_editor/image_editor.js View 2 chunks +9 lines, -1 line 0 comments Download
M ui/file_manager/gallery/js/image_editor/image_transform.js View 1 3 chunks +42 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
hirono
PTAL the CL? Thank you!
6 years, 5 months ago (2014-07-02 07:43:07 UTC) #1
mtomasz
lgtm https://codereview.chromium.org/363873002/diff/20001/ui/file_manager/gallery/js/image_editor/image_transform.js File ui/file_manager/gallery/js/image_editor/image_transform.js (right): https://codereview.chromium.org/363873002/diff/20001/ui/file_manager/gallery/js/image_editor/image_transform.js#newcode284 ui/file_manager/gallery/js/image_editor/image_transform.js:284: * It does not fixed aspect ratio when ...
6 years, 5 months ago (2014-07-02 07:56:54 UTC) #2
hirono
Thank you! https://codereview.chromium.org/363873002/diff/20001/ui/file_manager/gallery/js/image_editor/image_transform.js File ui/file_manager/gallery/js/image_editor/image_transform.js (right): https://codereview.chromium.org/363873002/diff/20001/ui/file_manager/gallery/js/image_editor/image_transform.js#newcode284 ui/file_manager/gallery/js/image_editor/image_transform.js:284: * It does not fixed aspect ratio ...
6 years, 5 months ago (2014-07-02 08:11:18 UTC) #3
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 5 months ago (2014-07-02 08:11:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/363873002/40001
6 years, 5 months ago (2014-07-02 08:11:57 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-02 10:12:01 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-02 16:38:48 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/34420)
6 years, 5 months ago (2014-07-02 16:38:49 UTC) #8
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 5 months ago (2014-07-03 02:15:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/363873002/40001
6 years, 5 months ago (2014-07-03 02:16:58 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-07-03 05:47:46 UTC) #11
Message was sent while issue was closed. 
Change committed as 281170

Powered by Google App Engine
This is Rietveld 408576698