Issue 363833004: Fix RecreateSkps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 363833004: Fix RecreateSkps (Closed)

Created:
6 years, 5 months ago by borenet

Modified:
6 years, 5 months ago

Reviewers:
rmistry

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Fix RecreateSkps - Use shell_utils to auto-print all subprocesses. - Only download bench_pictures data. - Skip or error out on bots which failed BenchPictures, PostBench, or UploadBenchResults. BUG=skia:2714 TBR=rmistry NOTRY=true Committed: https://skia.googlesource.com/skia/+/b26130af2faf6a72b077c400557e638e89c339d4

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -16 lines)			Patch
	M	tools/gen_bench_expectations_from_codereview.py	View	1 2	8 chunks	+71 lines, -16 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/borenet@google.com/363833004/40001

6 years, 5 months ago (2014-07-02 16:36:59 UTC) #3

commit-bot: I haz the power

6 years, 5 months ago (2014-07-02 16:37:07 UTC) #4

Message was sent while issue was closed.

Change committed as b26130af2faf6a72b077c400557e638e89c339d4