Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 363823004: DevTools: Do not load css resources content before CSS agent is enabled. (Closed)

Created:
6 years, 5 months ago by vsevik
Modified:
6 years, 5 months ago
Reviewers:
lushnikov, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Do not load css resources content before CSS agent is enabled. R=pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177405

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -7 lines) Patch
M LayoutTests/inspector-protocol/page/enable-disable.html View 1 chunk +1 line, -0 lines 0 comments Download
A + LayoutTests/inspector-protocol/resources/style.css View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorCSSAgent.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorPageAgent.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorResourceContentLoader.h View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorResourceContentLoader.cpp View 1 2 2 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
vsevik
PTAL
6 years, 5 months ago (2014-07-02 14:56:34 UTC) #1
lushnikov
lgtm
6 years, 5 months ago (2014-07-02 15:37:31 UTC) #2
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 5 months ago (2014-07-02 15:39:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/363823004/40001
6 years, 5 months ago (2014-07-02 15:40:24 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-02 16:41:13 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-02 17:31:30 UTC) #6
Message was sent while issue was closed.
Change committed as 177405

Powered by Google App Engine
This is Rietveld 408576698