Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: media/base/video_rotation.h

Issue 363813002: Update to Pipeline Metadata and Decoder Stream for Orientation Data (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Split enum to own file Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/video_rotation.h
diff --git a/media/base/video_rotation.h b/media/base/video_rotation.h
new file mode 100644
index 0000000000000000000000000000000000000000..b688b77bbc4bbb2255a21e681651fa386b44083c
--- /dev/null
+++ b/media/base/video_rotation.h
@@ -0,0 +1,19 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
scherkus (not reviewing) 2014/07/07 22:41:11 nit: it's 2014 :)
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef MEDIA_BASE_VIDEO_ROTATION_H
scherkus (not reviewing) 2014/07/07 22:41:11 include guards end with a trailing _
+#define MEDIA_BASE_VIDEO_ROTATION_H
+
+namespace media {
+
+// Enumeration to rerpesent 90 degree video rotation for mov/mp4 videos
scherkus (not reviewing) 2014/07/07 22:41:11 typo: represent
+// where it can be rotated by 90 degree intervals
scherkus (not reviewing) 2014/07/07 22:41:11 nit: sentences should end with periods
+enum VideoRotation {
+ VIDEO_ROTATION_0 = 0,
+ VIDEO_ROTATION_90,
+ VIDEO_ROTATION_180,
+ VIDEO_ROTATION_270
+};
scherkus (not reviewing) 2014/07/07 22:41:11 general comment on vertical whitespace formatting:
+}
scherkus (not reviewing) 2014/07/07 22:41:11 we close off namespaces with two spaces + a commen
+#endif
scherkus (not reviewing) 2014/07/07 22:41:11 ditto for include guards #endif // MEDIA_BASE_VI

Powered by Google App Engine
This is Rietveld 408576698