Update to Pipeline Metadata and Decoder Stream for Orientation Data

media/base/video_rotation.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.

[scherkus (not reviewing), 2014/07/07 22:41:11]

nit: it's 2014 :)

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef MEDIA_BASE_VIDEO_ROTATION_H

[scherkus (not reviewing), 2014/07/07 22:41:11]

include guards end with a trailing _

+#define MEDIA_BASE_VIDEO_ROTATION_H
+
+namespace media {
+
+// Enumeration to rerpesent 90 degree video rotation for mov/mp4 videos

[scherkus (not reviewing), 2014/07/07 22:41:11]

typo: represent

+// where it can be rotated by 90 degree intervals

[scherkus (not reviewing), 2014/07/07 22:41:11]

nit: sentences should end with periods

+enum VideoRotation {
+  VIDEO_ROTATION_0 = 0,
+  VIDEO_ROTATION_90,
+  VIDEO_ROTATION_180,
+  VIDEO_ROTATION_270
+};

[scherkus (not reviewing), 2014/07/07 22:41:11]

general comment on vertical whitespace formatting: typically space out closing }
blocks with a blank line

add one here as well as after the closing namespace brace

+}

[scherkus (not reviewing), 2014/07/07 22:41:11]

we close off namespaces with two spaces + a comment

}  // namespace media

+#endif

[scherkus (not reviewing), 2014/07/07 22:41:11]

ditto for include guards

#endif  // MEDIA_BASE_VIDEO_ROTATION_H_