Update to Pipeline Metadata and Decoder Stream for Orientation Data

media/filters/ffmpeg_demuxer_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 #include <deque>
 #include <string>
 
 #include "base/bind.h"
 #include "base/files/file_path.h"
@@ skipping 898 matching lines @@
     message_loop_.Run();
 
     WaitableMessageLoopEvent event;
     demuxer_->Stop(event.GetClosure());
     event.RunAndWait();
     demuxer_.reset();
     data_source_.reset();
   }
 }
 
+TEST_F(FFmpegDemuxerTest, Rotate_Metadata_0) {
+  const char * file = "bear_rotate_0.mov";

[scherkus (not reviewing), 2014/07/09 22:15:16]

* goes with the type

GOOD: const char* foo
BAD: const char * foo
BAD: const char *foo

+  CreateDemuxer(file);
+  InitializeDemuxer();
+
+  DemuxerStream* stream = demuxer_->GetStream(DemuxerStream::VIDEO);
+  ASSERT_TRUE(stream);
+  ASSERT_TRUE(stream->video_rotation() == media::VIDEO_ROTATION_0);

[scherkus (not reviewing), 2014/07/09 22:15:16]

gtest's {EXPECT,ASSERT}_EQ() uses (expected, actual) ordering of arguments

also drop media:: prefixes inside media namespace

in other words:

ASSERT_EQ(VIDEO_ROTATION_0, stream->video_rotation());

+}
+
+TEST_F(FFmpegDemuxerTest, Rotate_Metadata_90) {
+  const char * file = "bear_rotate_90.mov";

[scherkus (not reviewing), 2014/07/09 22:15:16]

ditto

+  CreateDemuxer(file);
+  InitializeDemuxer();
+
+  DemuxerStream* stream = demuxer_->GetStream(DemuxerStream::VIDEO);
+  ASSERT_TRUE(stream);
+  ASSERT_TRUE(stream->video_rotation() == media::VIDEO_ROTATION_90);

[scherkus (not reviewing), 2014/07/09 22:15:16]

ditto

+}
+
+TEST_F(FFmpegDemuxerTest, Rotate_Metadata_180) {
+  const char * file = "bear_rotate_180.mov";

[scherkus (not reviewing), 2014/07/09 22:15:16]

ditto

+  CreateDemuxer(file);
+  InitializeDemuxer();
+
+  DemuxerStream* stream = demuxer_->GetStream(DemuxerStream::VIDEO);
+  ASSERT_TRUE(stream);
+  ASSERT_TRUE(stream->video_rotation() == media::VIDEO_ROTATION_180);

[scherkus (not reviewing), 2014/07/09 22:15:16]

ditto

+}
+
+TEST_F(FFmpegDemuxerTest, Rotate_Metadata_270) {
+  const char * file = "bear_rotate_270.mov";

[scherkus (not reviewing), 2014/07/09 22:15:16]

ditto

+  CreateDemuxer(file);
+  InitializeDemuxer();
+
+  DemuxerStream* stream = demuxer_->GetStream(DemuxerStream::VIDEO);
+  ASSERT_TRUE(stream);
+  ASSERT_TRUE(stream->video_rotation() == media::VIDEO_ROTATION_270);

[scherkus (not reviewing), 2014/07/09 22:15:16]

ditto

+}
+
 #endif
 
 }  // namespace media