Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Unified Diff: chrome/browser/browser_process_platform_part_chromeos.h

Issue 363613004: [cros] Define session_manager component with SessionManager base class (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: default to RestoreAfterCrashSessionManagerDelegate Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browser_process_platform_part_chromeos.h
diff --git a/chrome/browser/browser_process_platform_part_chromeos.h b/chrome/browser/browser_process_platform_part_chromeos.h
index e5c4b4648bf7c064b238fbfc1d257021d61ae6f6..1bc79dea696f78710cd7c4e8197d8c1765337909 100644
--- a/chrome/browser/browser_process_platform_part_chromeos.h
+++ b/chrome/browser/browser_process_platform_part_chromeos.h
@@ -10,6 +10,10 @@
#include "base/threading/non_thread_safe.h"
#include "chrome/browser/browser_process_platform_part_base.h"
+namespace base {
+class CommandLine;
+}
+
namespace chromeos {
class OomPriorityManager;
class ProfileHelper;
@@ -26,6 +30,12 @@ class BrowserPolicyConnector;
class BrowserPolicyConnectorChromeOS;
}
+namespace session_manager {
+class SessionManager;
+}
+
+class Profile;
+
class BrowserProcessPlatformPart : public BrowserProcessPlatformPartBase,
public base::NonThreadSafe {
public:
@@ -35,6 +45,16 @@ class BrowserProcessPlatformPart : public BrowserProcessPlatformPartBase,
void InitializeAutomaticRebootManager();
void ShutdownAutomaticRebootManager();
+ void InitializeSessionManager(const base::CommandLine& parsed_command_line,
+ Profile* profile,
+ bool is_running_test);
+ void ShutdownSessionManager();
+
+ // Returns the SessionManager instance that is used to initialize and
+ // start user sessions as well as responsible on launching pre-session UI like
+ // out-of-box or login.
+ virtual session_manager::SessionManager* session_manager();
jam 2014/07/16 05:42:43 nit: per style guide, virtual methods should use C
Nikita (slow) 2014/07/16 08:29:47 Done.
+
// Returns the out-of-memory priority manager.
// Virtual for testing (see TestingBrowserProcessPlatformPart).
virtual chromeos::OomPriorityManager* oom_priority_manager();
@@ -50,7 +70,7 @@ class BrowserProcessPlatformPart : public BrowserProcessPlatformPartBase,
policy::BrowserPolicyConnectorChromeOS* browser_policy_connector_chromeos();
// Overridden from BrowserProcessPlatformPartBase:
- virtual void StartTearDown() OVERRIDE;
+ virtual void StartTearDown() OVERRIDE;
virtual scoped_ptr<policy::BrowserPolicyConnector>
CreateBrowserPolicyConnector() OVERRIDE;
@@ -58,6 +78,8 @@ class BrowserProcessPlatformPart : public BrowserProcessPlatformPartBase,
private:
void CreateProfileHelper();
+ scoped_ptr<session_manager::SessionManager> session_manager_;
+
bool created_profile_helper_;
scoped_ptr<chromeos::ProfileHelper> profile_helper_;

Powered by Google App Engine
This is Rietveld 408576698