chrome/browser/extensions/api/serial/serial_io_handler_posix.h - Issue 363583002: Convert SerialIoHandler to use Mojo types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/serial/serial_io_handler_posix.h

Issue 363583002: Convert SerialIoHandler to use Mojo types. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/serial/serial_io_handler_posix.h

diff --git a/chrome/browser/extensions/api/serial/serial_io_handler_posix.h b/chrome/browser/extensions/api/serial/serial_io_handler_posix.h

index 1128e68dbaac4d1372caa266d499dcd94408652d..f33865b1641927f13c5e0de3b6fdb96e8bcd2482 100644

--- a/chrome/browser/extensions/api/serial/serial_io_handler_posix.h

+++ b/chrome/browser/extensions/api/serial/serial_io_handler_posix.h

@@ -19,13 +19,11 @@ class SerialIoHandlerPosix : public SerialIoHandler,

virtual void CancelReadImpl() OVERRIDE;

virtual void CancelWriteImpl() OVERRIDE;

virtual bool Flush() const OVERRIDE;

- virtual bool GetControlSignals(

- api::serial::DeviceControlSignals* control_signals) const OVERRIDE;

+ virtual device::DeviceControlSignalsPtr GetControlSignals() const OVERRIDE;

virtual bool SetControlSignals(

- const api::serial::HostControlSignals& control_signals) OVERRIDE;

- virtual bool ConfigurePort(

- const api::serial::ConnectionOptions& options) OVERRIDE;

- virtual bool GetPortInfo(api::serial::ConnectionInfo* info) const OVERRIDE;

+ const device::HostControlSignals& control_signals) OVERRIDE;

+ virtual bool ConfigurePort(const device::ConnectionOptions& options) OVERRIDE;

+ virtual device::ConnectionInfoPtr GetPortInfo() const OVERRIDE;

virtual bool PostOpen() OVERRIDE;

private: