Convert SerialIoHandler to use Mojo types.

Convert SerialIoHandler to use Mojo types.

BUG=389016
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280993

[Ken Rockot(use gerrit already), 2014-07-01 13:56:58]

LGTM overall, but I'm worried about future namespace collisions.
ConnectionOptions should probably be SerialConnectionOptions, etc.

Alternatively we could nest namespaces, like device::serial::. I tend to prefer
the nested namespaces, but it's not clear to me if that's preferential in
general (or even possible - can module names be nested in mojom?)

[darin (slow to review), 2014-07-01 15:07:27]

mojom does support nested namespaces. you can write "module foo.bar {" in a
mojom file to generate code in the foo::bar:: namespace.

-Darin


On Tue, Jul 1, 2014 at 6:56 AM, <rockot@chromium.org> wrote:

> LGTM overall, but I'm worried about future namespace collisions.
> ConnectionOptions should probably be SerialConnectionOptions, etc.
>
> Alternatively we could nest namespaces, like device::serial::. I tend to
> prefer
> the nested namespaces, but it's not clear to me if that's preferential in
> general (or even possible - can module names be nested in mojom?)
>
> https://codereview.chromium.org/363583002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[raymes, 2014-07-02 00:57:48]

https://codereview.chromium.org/363583002/diff/40001/chrome/browser/extension...
File chrome/browser/extensions/api/serial/serial_connection.cc (right):

https://codereview.chromium.org/363583002/diff/40001/chrome/browser/extension...
chrome/browser/extensions/api/serial/serial_connection.cc:23: default:
It's often good to get rid of the "default" case so that we get a compile error
if someone adds an enum value. (here and below)

[Sam McNally, 2014-07-02 04:50:50]

On 2014/07/01 13:56:58, Ken Rockot wrote:
> LGTM overall, but I'm worried about future namespace collisions.
> ConnectionOptions should probably be SerialConnectionOptions, etc.
> 
> Alternatively we could nest namespaces, like device::serial::. I tend to
prefer
> the nested namespaces, but it's not clear to me if that's preferential in
> general (or even possible - can module names be nested in mojom?)

Switched to device::serial::

https://codereview.chromium.org/363583002/diff/40001/chrome/browser/extension...
File chrome/browser/extensions/api/serial/serial_connection.cc (right):

https://codereview.chromium.org/363583002/diff/40001/chrome/browser/extension...
chrome/browser/extensions/api/serial/serial_connection.cc:23: default:
On 2014/07/02 00:57:48, raymes wrote:
> It's often good to get rid of the "default" case so that we get a compile
error
> if someone adds an enum value. (here and below)

Done.

[Sam McNally, 2014-07-02 04:51:15]

The CQ bit was checked by sammc@chromium.org

[commit-bot: I haz the power, 2014-07-02 04:52:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sammc@chromium.org/363583002/100001

[commit-bot: I haz the power, 2014-07-02 06:49:09]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-02 07:09:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-02 07:09:07]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[Sam McNally, 2014-07-02 07:09:42]

The CQ bit was checked by sammc@chromium.org

[commit-bot: I haz the power, 2014-07-02 07:10:41]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sammc@chromium.org/363583002/100001

[commit-bot: I haz the power, 2014-07-02 09:58:32]

Change committed as 280993