Source/core/html/shadow/MediaControls.cpp - Issue 363563007: Only show overlay play button when controls are enabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/shadow/MediaControls.cpp

Issue 363563007: Only show overlay play button when controls are enabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@shouldShowControls

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/shadow/MediaControls.cpp

diff --git a/Source/core/html/shadow/MediaControls.cpp b/Source/core/html/shadow/MediaControls.cpp

index a82cf61a972561ce95f6b1ac0a02448cd35400ed..7cf45f5a2dbef978f94fe66440edbff63f6f2876 100644

--- a/Source/core/html/shadow/MediaControls.cpp

+++ b/Source/core/html/shadow/MediaControls.cpp

@@ -203,6 +203,8 @@ void MediaControls::hide()

{

m_panel->setIsDisplayed(false);

m_panel->hide();

+ if (m_overlayPlayButton)

+ m_overlayPlayButton->hide();

acolwell GONE FROM CHROMIUM 2014/07/01 17:06:22 It seems like there should coorresponding "show" l

}

void MediaControls::makeOpaque()

« no previous file with comments | « Source/core/html/shadow/MediaControlElements.cpp ('k') | no next file » | no next file with comments »