Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 363563004: Move extensions-only render IPC messages into the extension messages header. (Closed)

Created:
6 years, 5 months ago by Lei Zhang
Modified:
6 years, 5 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Move extensions-only render IPC messages into the extension messages header. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282274

Patch Set 1 #

Total comments: 1

Patch Set 2 : small style fix #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -63 lines) Patch
M chrome/browser/extensions/chrome_extension_web_contents_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/guest_view/web_view/web_view_guest.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/chrome_extension_message_filter.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/apps/chrome_app_window_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/common_message_generator.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/chrome_extension_messages.h View 1 2 3 chunks +50 lines, -7 lines 0 comments Download
M chrome/common/render_messages.h View 1 2 3 7 chunks +0 lines, -50 lines 0 comments Download
M chrome/renderer/chrome_render_view_observer.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/renderer/content_settings_observer.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/renderer/extensions/chrome_extensions_render_frame_observer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
Lei Zhang
6 years, 5 months ago (2014-07-01 01:58:36 UTC) #1
Lei Zhang
https://codereview.chromium.org/363563004/diff/1/chrome/common/extensions/chrome_extension_messages.h File chrome/common/extensions/chrome_extension_messages.h (right): https://codereview.chromium.org/363563004/diff/1/chrome/common/extensions/chrome_extension_messages.h#newcode101 chrome/common/extensions/chrome_extension_messages.h:101: int32 /* severity level */) I suppose I should ...
6 years, 5 months ago (2014-07-02 21:42:41 UTC) #2
Tom Sepez
LGTM on moving messages around.
6 years, 5 months ago (2014-07-02 21:51:21 UTC) #3
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 5 months ago (2014-07-02 21:55:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/363563004/40001
6 years, 5 months ago (2014-07-02 21:58:31 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-03 03:14:48 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-03 04:27:44 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/builds/48204)
6 years, 5 months ago (2014-07-03 04:27:45 UTC) #8
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 5 months ago (2014-07-10 02:34:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/363563004/80001
6 years, 5 months ago (2014-07-10 02:35:58 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-10 06:01:35 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 07:49:40 UTC) #12
Message was sent while issue was closed. 
Change committed as 282274

Powered by Google App Engine
This is Rietveld 408576698