Issue 363553005: Add ScriptID field into ScriptOrigin class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 363553005: Add ScriptID field into ScriptOrigin class. (Closed)

Created:
6 years, 5 months ago by kozyatinskiy1

Modified:
6 years, 5 months ago

Reviewers:
vsevik, ulan, Yang

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
git://github.com/v8/v8.git@master

Project:
v8

Visibility:
Public.

Add ScriptID field into ScriptOrigin class. Anonymous script has empty resource name. To identify this script we need its id. R=ulan@chromium.org, yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22248

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -3 lines)			Patch
	M	include/v8.h	View		2 chunks	+12 lines, -2 lines	0 comments	Download
	M	src/api.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 7 (0 generated)

Yang

On 2014/07/01 14:03:54, kozyatinskiy wrote: > Yang, please take a look. LGTM. Adding Ulan as ...

6 years, 5 months ago (2014-07-01 14:12:33 UTC) #3

yurys

6 years, 5 months ago (2014-07-07 14:03:35 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 manually as r22248 (presubmit successful).