sdk/lib/_internal/pub/lib/src/barback/transformers_needed_by_transformers.dart - Issue 363543003: Don't load dependencies' useless transformers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub/lib/src/barback/transformers_needed_by_transformers.dart

Issue 363543003: Don't load dependencies' useless transformers. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: code review Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/pub/lib/src/barback/transformer_config.dart ('k') | sdk/lib/_internal/pub/test/transformers_needed_by_transformers/dev_transformers_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/pub/lib/src/barback/transformers_needed_by_transformers.dart

diff --git a/sdk/lib/_internal/pub/lib/src/barback/transformers_needed_by_transformers.dart b/sdk/lib/_internal/pub/lib/src/barback/transformers_needed_by_transformers.dart

index e61e1c49400779d1c979166e24054f0ac3cd635d..6401105a488693d4d585e90f73348b0bf7cfaf9c 100644

--- a/sdk/lib/_internal/pub/lib/src/barback/transformers_needed_by_transformers.dart

+++ b/sdk/lib/_internal/pub/lib/src/barback/transformers_needed_by_transformers.dart

@@ -35,6 +35,10 @@ Map<TransformerId, Set<TransformerId>> computeTransformersNeededByTransformers(

for (var config in phase) {

var id = config.id;

if (id.isBuiltInTransformer) continue;

+ if (id.package != graph.entrypoint.root.name &&

+ !config.canTransformPublicFiles) {

+ continue;

+ }

result[id] = computer.transformersNeededByTransformer(id);

}