Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 363493002: Add UseCounter for the Mozilla-style fullscreen error handling exemptions (Closed)

Created:
6 years, 5 months ago by philipj_slow
Modified:
6 years, 5 months ago
Reviewers:
falken
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Project:
blink
Visibility:
Public.

Description

Add UseCounter for the Mozilla-style fullscreen error handling exemptions webkitRequestFullScreen skips some checks that webkitRequestFullscreen and other modes have. It is unlikely that the prefixed fullscreen APIs can be removed any time soon, so trying to reduce the differences between them is worthwhile. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177284

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -5 lines) Patch
M Source/core/dom/FullscreenElementStack.cpp View 2 chunks +13 lines, -5 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
philipj_slow
6 years, 5 months ago (2014-06-30 22:52:57 UTC) #1
falken
On 2014/06/30 22:52:57, philipj wrote: lgtm... it could be nice to make the change description ...
6 years, 5 months ago (2014-07-01 05:12:20 UTC) #2
philipj_slow
On 2014/07/01 05:12:20, falken wrote: > On 2014/06/30 22:52:57, philipj wrote: > > lgtm... it ...
6 years, 5 months ago (2014-07-01 07:10:14 UTC) #3
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 5 months ago (2014-07-01 07:10:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/363493002/1
6 years, 5 months ago (2014-07-01 07:12:37 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-01 07:12:48 UTC) #6
commit-bot: I haz the power
Failed to apply patch for Source/core/frame/UseCounter.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 5 months ago (2014-07-01 07:12:49 UTC) #7
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 5 months ago (2014-07-01 07:31:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/363493002/20001
6 years, 5 months ago (2014-07-01 07:32:35 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-01 08:40:33 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-07-01 09:45:36 UTC) #11
Message was sent while issue was closed.
Change committed as 177284

Powered by Google App Engine
This is Rietveld 408576698