Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 363483002: Reenable PanelViewTest.CheckTitleOnlyHeight and PanelViewTest.CheckMinimizedHeight (Closed)

Created:
6 years, 5 months ago by pkotwicz
Modified:
6 years, 5 months ago
CC:
chromium-reviews, tfarina, jennb, jianli, Dmitry Titov, dcheng
Project:
chromium
Visibility:
Public.

Description

Reenable PanelViewTest.CheckTitleOnlyHeight and PanelViewTest.CheckMinimizedHeight The panel's minimum size depends on whether the panel is minimized. This CL ensures that when a panel is minimized, the X window's minimum size is first updated, then the X window's bounds are updated (to be smaller than the non-minimized panel minimum size allows) BUG=382301 TEST=PanelViewTest.* R=erg TBR=dimich (For reenabling tests in panel_view_browsertest.cc) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283945

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -40 lines) Patch
M chrome/browser/ui/views/panels/panel_view_browsertest.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_win.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h View 4 chunks +11 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 3 chunks +46 lines, -27 lines 2 comments Download
M ui/views/widget/native_widget_aura.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/native_widget_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/native_widget_private.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
pkotwicz
Elliot, can you please take a look? https://codereview.chromium.org/363483002/diff/20001/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc File ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc (right): https://codereview.chromium.org/363483002/diff/20001/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc#newcode1241 ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:1241: return; In ...
6 years, 5 months ago (2014-07-17 17:39:07 UTC) #1
Elliot Glaysher
lgtm https://codereview.chromium.org/363483002/diff/20001/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc File ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc (right): https://codereview.chromium.org/363483002/diff/20001/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc#newcode1241 ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:1241: return; On 2014/07/17 17:39:07, pkotwicz wrote: > In ...
6 years, 5 months ago (2014-07-17 18:15:29 UTC) #2
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 5 months ago (2014-07-17 19:26:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/363483002/20001
6 years, 5 months ago (2014-07-17 19:29:37 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-17 23:18:54 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 00:25:00 UTC) #6
Message was sent while issue was closed.
Change committed as 283945

Powered by Google App Engine
This is Rietveld 408576698