Add gn support for libsrtp

Add gn support for libsrtp

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280764

[rvargas (doing something else), 2014-06-30 23:30:50]

I'm not sure if secondary tree is the right place, but ICU also comes from
trunk/deps.

Is there a way to add/remove configs from a configuration? (like to say that
libsrtp_config is not chromium code)

[brettw, 2014-06-30 23:52:16]

On 2014/06/30 23:30:50, rvargas wrote:
> I'm not sure if secondary tree is the right place, but ICU also comes from
> trunk/deps.

if we deps it in then it either should go upstream or in the secondary tree.
Upstream is better but is an extra step and I usually let the team responsible
for that component do it fi they want.

> Is there a way to add/remove configs from a configuration? (like to say that
> libsrtp_config is not chromium code)

Yes, check out the "Chromium code" section:
https://code.google.com/p/chromium/wiki/GNCookbook

[brettw, 2014-06-30 23:54:47]

On 2014/06/30 23:52:16, brettw wrote:
> On 2014/06/30 23:30:50, rvargas wrote:
> > I'm not sure if secondary tree is the right place, but ICU also comes from
> > trunk/deps.
> 
> if we deps it in then it either should go upstream or in the secondary tree.
> Upstream is better but is an extra step and I usually let the team responsible
> for that component do it fi they want.
> 
> > Is there a way to add/remove configs from a configuration? (like to say that
> > libsrtp_config is not chromium code)
> 
> Yes, check out the "Chromium code" section:
> https://code.google.com/p/chromium/wiki/GNCookbook

Oh, you already did that. The way you have it is the only way. In some cases
(like this one) it's annoying, but so far this hasn't justified adding some new
language feature to make it easier.

LGTM!

[brettw, 2014-06-30 23:54:53]

https://codereview.chromium.org/363473003/diff/90001/build/secondary/third_pa...
File build/secondary/third_party/libsrtp/BUILD.gn (right):

https://codereview.chromium.org/363473003/diff/90001/build/secondary/third_pa...
build/secondary/third_party/libsrtp/BUILD.gn:16: "./config",
You don't need "./"

https://codereview.chromium.org/363473003/diff/90001/build/secondary/third_pa...
build/secondary/third_party/libsrtp/BUILD.gn:71: libs += [ "-lsrtp" ]
+= should be =

[rvargas (doing something else), 2014-07-01 00:34:28]

Thanks!

https://codereview.chromium.org/363473003/diff/90001/build/secondary/third_pa...
File build/secondary/third_party/libsrtp/BUILD.gn (right):

https://codereview.chromium.org/363473003/diff/90001/build/secondary/third_pa...
build/secondary/third_party/libsrtp/BUILD.gn:16: "./config",
On 2014/06/30 23:54:53, brettw wrote:
> You don't need "./"

Done.

https://codereview.chromium.org/363473003/diff/90001/build/secondary/third_pa...
build/secondary/third_party/libsrtp/BUILD.gn:71: libs += [ "-lsrtp" ]
On 2014/06/30 23:54:53, brettw wrote:
> += should be =

Done.

[rvargas (doing something else), 2014-07-01 00:56:35]

The CQ bit was checked by rvargas@chromium.org

[commit-bot: I haz the power, 2014-07-01 00:57:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rvargas@chromium.org/363473003/110001

[commit-bot: I haz the power, 2014-07-01 07:03:28]

Change committed as 280764