Issue 363443002: Prevent garbage collection from deleting a context during its eviction.

Issue 363443002: Prevent garbage collection from deleting a context during its eviction. (Closed)

Created:
6 years, 5 months ago by Zhenyao Mo

Modified:
6 years, 5 months ago

Reviewers:
Ken Russell (switch to Gerrit)

CC:
blink-reviews, aandrey+blink_chromium.org, blink-reviews-html_chromium.org, dglazkov+blink, Rik, bajones

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Prevent garbage collection from deleting a context during its eviction. BUG=374086 TEST=gpu linux debug bot on webkit waterfall, no random crashes R=kbr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177435

Patch Set 2 : fix typo #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -41 lines)			Patch
	M	LayoutTests/TestExpectations	View	1	1 chunk	+0 lines, -10 lines	0 comments	Download
	M	Source/core/html/canvas/WebGLRenderingContextBase.cpp	View	1	9 chunks	+6 lines, -31 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Ken Russell (switch to Gerrit)

LGTM It would be ideal if we could modify the context-creation-and-destruction test (or another one) ...

6 years, 5 months ago (2014-06-30 18:28:58 UTC) #2

Zhenyao Mo

conformance/context/context-eviction-with-garbage-collection.html is added to the WebGL conformance test suites. https://codereview.chromium.org/363443002/diff/40001/Source/core/html/canvas/WebGLRenderingContextBase.cpp File Source/core/html/canvas/WebGLRenderingContextBase.cpp (right): https://codereview.chromium.org/363443002/diff/40001/Source/core/html/canvas/WebGLRenderingContextBase.cpp#newcode117 Source/core/html/canvas/WebGLRenderingContextBase.cpp:117: ...

6 years, 5 months ago (2014-07-02 22:45:23 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zmo@chromium.org/363443002/60001

6 years, 5 months ago (2014-07-02 22:45:36 UTC) #5

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...

6 years, 5 months ago (2014-07-02 23:59:07 UTC) #6

Message was sent while issue was closed.

Change committed as 177435

Expand Messages | Collapse Messages