Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 363433002: DirectWrite to detect GDI only fonts. (Closed)

Created:
6 years, 5 months ago by bungeman-skia
Modified:
6 years, 5 months ago
Reviewers:
mtklein, eae, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

DirectWrite to detect GDI only fonts. The exist a number of webfonts which have poor hinting which look very bad with any vertical subsampling. The fonts often rely on drop out control to avoid zero coverage in the y direction. As a result, any font with hints but no 'gasp' table is considered to be poorly hinted in this way, and will not be rendered with vertical subsampling when hinted. Committed: https://skia.googlesource.com/skia/+/761b2509d59787a8920b2e98911cff9f88e0eb4e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
M src/ports/SkScalerContext_win_dw.cpp View 4 chunks +36 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
bungeman-skia
This should 'fix' some poorly hinted webfonts, by making them look about as poorly hinted ...
6 years, 5 months ago (2014-06-30 17:49:02 UTC) #1
bungeman-skia
6 years, 5 months ago (2014-06-30 18:15:40 UTC) #2
mtklein
lgtm
6 years, 5 months ago (2014-06-30 18:32:06 UTC) #3
bungeman-skia
The CQ bit was checked by bungeman@google.com
6 years, 5 months ago (2014-06-30 19:04:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bungeman@google.com/363433002/1
6 years, 5 months ago (2014-06-30 19:05:47 UTC) #5
commit-bot: I haz the power
Change committed as 761b2509d59787a8920b2e98911cff9f88e0eb4e
6 years, 5 months ago (2014-06-30 19:19:44 UTC) #6
eae
6 years, 5 months ago (2014-06-30 19:37:11 UTC) #7
Message was sent while issue was closed.
On 2014/06/30 19:19:44, I haz the power (commit-bot) wrote:
> Change committed as 761b2509d59787a8920b2e98911cff9f88e0eb4e

Very nice, thanks Ben!

LGTM (post facto).

Powered by Google App Engine
This is Rietveld 408576698