Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 363383007: [fsp] Cleanup operations' unit tests. (Closed)

Created:
6 years, 5 months ago by mtomasz
Modified:
6 years, 5 months ago
Reviewers:
kinaba
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

[fsp] Cleanup operations' unit tests. Repeated code has been extracted to a separate file. Moreover, the logger for the StatusCallback has been replaced with a simpler solution. TEST=unit_tests: *FileSystemProviderOperation* BUG=248427 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281390

Patch Set 1 #

Patch Set 2 : Uploaded a missing file. #

Total comments: 2

Patch Set 3 : Fixed. #

Messages

Total messages: 8 (0 generated)
mtomasz
@kinaba: PTAL. Thanks.
6 years, 5 months ago (2014-07-04 05:01:58 UTC) #1
kinaba
On 2014/07/04 05:01:58, mtomasz wrote: > @kinaba: PTAL. Thanks. Could you upload test_util.h?
6 years, 5 months ago (2014-07-04 05:52:34 UTC) #2
mtomasz
Oops. Done.
6 years, 5 months ago (2014-07-04 05:57:15 UTC) #3
kinaba
lgtm https://codereview.chromium.org/363383007/diff/20001/chrome/chrome_tests_unit.gypi File chrome/chrome_tests_unit.gypi (right): https://codereview.chromium.org/363383007/diff/20001/chrome/chrome_tests_unit.gypi#newcode740 chrome/chrome_tests_unit.gypi:740: 'browser/chromeos/file_system_provider/operations/test_util.h', sort alphabetically
6 years, 5 months ago (2014-07-04 06:25:28 UTC) #4
mtomasz
https://codereview.chromium.org/363383007/diff/20001/chrome/chrome_tests_unit.gypi File chrome/chrome_tests_unit.gypi (right): https://codereview.chromium.org/363383007/diff/20001/chrome/chrome_tests_unit.gypi#newcode740 chrome/chrome_tests_unit.gypi:740: 'browser/chromeos/file_system_provider/operations/test_util.h', On 2014/07/04 06:25:28, kinaba wrote: > sort alphabetically ...
6 years, 5 months ago (2014-07-04 07:56:33 UTC) #5
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 5 months ago (2014-07-04 07:56:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/363383007/40001
6 years, 5 months ago (2014-07-04 07:57:43 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-04 11:18:40 UTC) #8
Message was sent while issue was closed.
Change committed as 281390

Powered by Google App Engine
This is Rietveld 408576698