Replace MessageLoopProxy::current() with ThreadTaskRunnerHandle::Get()

Replace MessageLoopProxy::current() with ThreadTaskRunnerHandle::Get()

BUG=391045
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281515

[tzik, 2014-07-04 05:01:25]

PTL.

Per MessageLoopProxy deprecation, I'd sed through sync_file_system.

[peria, 2014-07-04 05:28:03]

Finished reviewing drive_backend/.

https://codereview.chromium.org/363373003/diff/1/chrome/browser/sync_file_sys...
File chrome/browser/sync_file_system/drive_backend/callback_helper_unittest.cc
(right):

https://codereview.chromium.org/363373003/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/drive_backend/callback_helper_unittest.cc:11: 
#include "base/thread_task_runner_handle.h" ?

https://codereview.chromium.org/363373003/diff/1/chrome/browser/sync_file_sys...
File chrome/browser/sync_file_system/drive_backend/metadata_database.cc (right):

https://codereview.chromium.org/363373003/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/drive_backend/metadata_database.cc:16: #include
"base/single_thread_task_runner.h"
I'm not sure, but doesn't "sequenced_task_runner.h" cover enough?

https://codereview.chromium.org/363373003/diff/1/chrome/browser/sync_file_sys...
File chrome/browser/sync_file_system/drive_backend/sync_engine.cc (right):

https://codereview.chromium.org/363373003/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/drive_backend/sync_engine.cc:8: 
add #include "base/thread_task_runner_handle.h" ?

https://codereview.chromium.org/363373003/diff/1/chrome/browser/sync_file_sys...
File chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc
(right):

https://codereview.chromium.org/363373003/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc:6: 
add #include "base/thread_task_runner_handle.h" ?

[peria, 2014-07-04 05:31:05]

Finish reviewing drive_backend_v1/.

https://codereview.chromium.org/363373003/diff/1/chrome/browser/sync_file_sys...
File chrome/browser/sync_file_system/drive_backend_v1/fake_api_util.cc (right):

https://codereview.chromium.org/363373003/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/drive_backend_v1/fake_api_util.cc:11: #include
"base/single_thread_task_runner.h"
Can we drop this #include?

[peria, 2014-07-04 05:36:44]

https://codereview.chromium.org/363373003/diff/1/chrome/browser/sync_file_sys...
File chrome/browser/sync_file_system/drive_backend_v1/fake_api_util.cc (right):

https://codereview.chromium.org/363373003/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/drive_backend_v1/fake_api_util.cc:11: #include
"base/single_thread_task_runner.h"
On 2014/07/04 05:31:05, peria wrote:
> Can we drop this #include?

Please ignore this comment.

https://codereview.chromium.org/363373003/diff/1/chrome/browser/sync_file_sys...
File chrome/browser/sync_file_system/local/local_file_sync_service.cc (right):

https://codereview.chromium.org/363373003/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/local/local_file_sync_service.cc:6: 
Add #include "base/single_thread_task_runner.h" ?

https://codereview.chromium.org/363373003/diff/1/chrome/browser/sync_file_sys...
File chrome/browser/sync_file_system/local/local_file_sync_service_unittest.cc
(right):

https://codereview.chromium.org/363373003/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/local/local_file_sync_service_unittest.cc:6: 
Add #include "base/single_thread_task_runner.h" ?

https://codereview.chromium.org/363373003/diff/1/chrome/browser/sync_file_sys...
File chrome/browser/sync_file_system/sync_file_system_service.cc (right):

https://codereview.chromium.org/363373003/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/sync_file_system_service.cc:8: 
Add #include "base/single_thread_task_runner.h" ?

https://codereview.chromium.org/363373003/diff/1/chrome/browser/sync_file_sys...
File chrome/browser/sync_file_system/sync_file_system_service_unittest.cc
(right):

https://codereview.chromium.org/363373003/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/sync_file_system_service_unittest.cc:6: 
Add #include "base/single_thread_task_runner.h" ?

[tzik, 2014-07-04 05:58:13]

https://codereview.chromium.org/363373003/diff/1/chrome/browser/sync_file_sys...
File chrome/browser/sync_file_system/drive_backend/callback_helper_unittest.cc
(right):

https://codereview.chromium.org/363373003/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/drive_backend/callback_helper_unittest.cc:11: 
On 2014/07/04 05:28:03, peria wrote:
> #include "base/thread_task_runner_handle.h" ?

Done.

https://codereview.chromium.org/363373003/diff/1/chrome/browser/sync_file_sys...
File chrome/browser/sync_file_system/drive_backend/metadata_database.cc (right):

https://codereview.chromium.org/363373003/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/drive_backend/metadata_database.cc:16: #include
"base/single_thread_task_runner.h"
On 2014/07/04 05:28:03, peria wrote:
> I'm not sure, but doesn't "sequenced_task_runner.h" cover enough?

Since ThreadTaskRunnerHanle::Get() returns a refptr to SingleThreadTaskRunner,
we have to tell the compiler the fact that SingleThreadTaskRunner is a
TaskRunner by #include'ing the header.

https://codereview.chromium.org/363373003/diff/1/chrome/browser/sync_file_sys...
File chrome/browser/sync_file_system/drive_backend/sync_engine.cc (right):

https://codereview.chromium.org/363373003/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/drive_backend/sync_engine.cc:8: 
On 2014/07/04 05:28:03, peria wrote:
> add #include "base/thread_task_runner_handle.h" ?

Done.

https://codereview.chromium.org/363373003/diff/1/chrome/browser/sync_file_sys...
File chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc
(right):

https://codereview.chromium.org/363373003/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc:6: 
On 2014/07/04 05:28:03, peria wrote:
> add #include "base/thread_task_runner_handle.h" ?

Done.
That was from callback_helper.h.

https://codereview.chromium.org/363373003/diff/1/chrome/browser/sync_file_sys...
File chrome/browser/sync_file_system/local/local_file_sync_service.cc (right):

https://codereview.chromium.org/363373003/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/local/local_file_sync_service.cc:6: 
On 2014/07/04 05:36:44, peria wrote:
> Add #include "base/single_thread_task_runner.h" ?

Done.
That was from browser_thread.

https://codereview.chromium.org/363373003/diff/1/chrome/browser/sync_file_sys...
File chrome/browser/sync_file_system/local/local_file_sync_service_unittest.cc
(right):

https://codereview.chromium.org/363373003/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/local/local_file_sync_service_unittest.cc:6: 
On 2014/07/04 05:36:44, peria wrote:
> Add #include "base/single_thread_task_runner.h" ?

Done.
Looks like threading/thread.h #include's it via message_loop_proxy.h.

https://codereview.chromium.org/363373003/diff/1/chrome/browser/sync_file_sys...
File chrome/browser/sync_file_system/sync_file_system_service.cc (right):

https://codereview.chromium.org/363373003/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/sync_file_system_service.cc:8: 
On 2014/07/04 05:36:44, peria wrote:
> Add #include "base/single_thread_task_runner.h" ?

Done.
That was #include'd by browser_thread.h.

https://codereview.chromium.org/363373003/diff/1/chrome/browser/sync_file_sys...
File chrome/browser/sync_file_system/sync_file_system_service_unittest.cc
(right):

https://codereview.chromium.org/363373003/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/sync_file_system_service_unittest.cc:6: 
On 2014/07/04 05:36:44, peria wrote:
> Add #include "base/single_thread_task_runner.h" ?

Done.
That was from run_loop.h.

[peria, 2014-07-04 06:22:30]

lgtm

https://codereview.chromium.org/363373003/diff/1/chrome/browser/sync_file_sys...
File chrome/browser/sync_file_system/drive_backend/metadata_database.cc (right):

https://codereview.chromium.org/363373003/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/drive_backend/metadata_database.cc:16: #include
"base/single_thread_task_runner.h"
On 2014/07/04 05:58:12, tzik wrote:
> On 2014/07/04 05:28:03, peria wrote:
> > I'm not sure, but doesn't "sequenced_task_runner.h" cover enough?
> 
> Since ThreadTaskRunnerHanle::Get() returns a refptr to SingleThreadTaskRunner,
> we have to tell the compiler the fact that SingleThreadTaskRunner is a
> TaskRunner by #include'ing the header.

All right. Thanks.

[tzik, 2014-07-04 06:36:23]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2014-07-04 06:37:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tzik@chromium.org/363373003/20001

[commit-bot: I haz the power, 2014-07-04 13:39:35]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-04 17:16:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-04 17:16:46]

Try jobs failed on following builders:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[tzik, 2014-07-07 02:11:48]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2014-07-07 02:12:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tzik@chromium.org/363373003/20001

[commit-bot: I haz the power, 2014-07-07 02:17:11]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-07 02:21:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-07 02:21:02]

Try jobs failed on following builders:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[tzik, 2014-07-07 03:13:55]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2014-07-07 03:14:54]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tzik@chromium.org/363373003/40001

[commit-bot: I haz the power, 2014-07-07 06:25:22]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-07 09:59:04]

Change committed as 281515