Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1344)

Unified Diff: Source/core/rendering/RenderDeprecatedFlexibleBox.cpp

Issue 363343005: Remove support for anonymous deprecated flexboxes. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/rendering/RenderDeprecatedFlexibleBox.h ('k') | Source/core/rendering/RenderObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderDeprecatedFlexibleBox.cpp
diff --git a/Source/core/rendering/RenderDeprecatedFlexibleBox.cpp b/Source/core/rendering/RenderDeprecatedFlexibleBox.cpp
index 0e8c492832e24ee0c77f761db697db881847e010..0b466a98a2616ee95e600b4e118286092bd5c683 100644
--- a/Source/core/rendering/RenderDeprecatedFlexibleBox.cpp
+++ b/Source/core/rendering/RenderDeprecatedFlexibleBox.cpp
@@ -118,31 +118,17 @@ private:
int m_ordinalIteration;
};
-RenderDeprecatedFlexibleBox::RenderDeprecatedFlexibleBox(Element* element)
- : RenderBlock(element)
+RenderDeprecatedFlexibleBox::RenderDeprecatedFlexibleBox(Element& element)
+ : RenderBlock(&element)
{
setChildrenInline(false); // All of our children must be block-level
m_stretchingChildren = false;
- if (!isAnonymous()) {
cbiesinger 2014/08/06 03:00:30 This entire if block needs to stay. The webkit pat
harpreet.sk 2014/08/06 13:22:14 Done.
- const KURL& url = document().url();
- if (url.protocolIs("chrome"))
- UseCounter::count(document(), UseCounter::DeprecatedFlexboxChrome);
- else if (url.protocolIs("chrome-extension"))
- UseCounter::count(document(), UseCounter::DeprecatedFlexboxChromeExtension);
- else
- UseCounter::count(document(), UseCounter::DeprecatedFlexboxWebContent);
- }
-}
-RenderDeprecatedFlexibleBox::~RenderDeprecatedFlexibleBox()
-{
+ UseCounter::count(document(), UseCounter::DeprecatedFlexboxWebContent);
}
-RenderDeprecatedFlexibleBox* RenderDeprecatedFlexibleBox::createAnonymous(Document* document)
+RenderDeprecatedFlexibleBox::~RenderDeprecatedFlexibleBox()
{
- RenderDeprecatedFlexibleBox* renderer = new RenderDeprecatedFlexibleBox(0);
- renderer->setDocumentForAnonymous(document);
- return renderer;
}
static LayoutUnit marginWidthForChild(RenderBox* child)
« no previous file with comments | « Source/core/rendering/RenderDeprecatedFlexibleBox.h ('k') | Source/core/rendering/RenderObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698