Remove support for anonymous deprecated flexboxes.

Remove support for anonymous deprecated flexboxes.

There are no remaining internal clients of RenderDeprecatedFlexibleBox,
so removing support for anonymous deprecated flexboxes.

These changes has been taken from following WebKit patch
http://trac.webkit.org/changeset/155689

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179655

[harpreet.sk, 2014-07-07 14:50:51]

ptal..

[tony, 2014-07-07 16:59:38]

cbiesinger would be a good reviewer for this.

[harpreet.sk, 2014-07-08 17:10:06]

@Christian can you please review the change...

[cbiesinger, 2014-08-06 03:00:30]

https://codereview.chromium.org/363343005/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderDeprecatedFlexibleBox.cpp (left):

https://codereview.chromium.org/363343005/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderDeprecatedFlexibleBox.cpp:126: if (!isAnonymous()) {
This entire if block needs to stay. The webkit patch removed it because they
don't use UseCounter, but we do want to keep counting how often deprecated
flexboxes are used.

[harpreet.sk, 2014-08-06 13:22:14]

Incorporated the changes asked. Please take a look.

https://codereview.chromium.org/363343005/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderDeprecatedFlexibleBox.cpp (left):

https://codereview.chromium.org/363343005/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderDeprecatedFlexibleBox.cpp:126: if (!isAnonymous()) {
On 2014/08/06 03:00:30, cbiesinger wrote:
> This entire if block needs to stay. The webkit patch removed it because they
> don't use UseCounter, but we do want to keep counting how often deprecated
> flexboxes are used.

Done.

[cbiesinger, 2014-08-06 13:51:30]

lgtm

[harpreet.sk, 2014-08-06 14:25:01]

@leviw: Requires owner's lgtm

[leviw_travelin_and_unemployed, 2014-08-06 18:11:29]

lgtm

[harpreet.sk, 2014-08-06 18:25:37]

The CQ bit was checked by harpreet.sk@samsung.com

[commit-bot: I haz the power, 2014-08-06 18:26:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/harpreet.sk@samsung.com/363343005/20001

[commit-bot: I haz the power, 2014-08-06 20:54:11]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_compile_dbg/bu...)

[commit-bot: I haz the power, 2014-08-06 21:19:16]

Change committed as 179655