Source/devtools/front_end/timeline/TimelineView.js - Issue 363343004: DevTools: Unify main thread name across vanilla and tracing timeline modes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/timeline/TimelineView.js

Issue 363343004: DevTools: Unify main thread name across vanilla and tracing timeline modes. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/devtools/front_end/timeline/TimelineModelImpl.js ('k') | Source/devtools/front_end/timeline/TracingTimelineModel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/timeline/TimelineView.js

diff --git a/Source/devtools/front_end/timeline/TimelineView.js b/Source/devtools/front_end/timeline/TimelineView.js

index 763babf10969cb786231f8a948e58ef0828c923f..cbd3732c4388f36cbb17b04a5524aebd80b5279c 100644

--- a/Source/devtools/front_end/timeline/TimelineView.js

+++ b/Source/devtools/front_end/timeline/TimelineView.js

@@ -1067,7 +1067,7 @@ WebInspector.TimelineRecordListRow.prototype = {

for (var currentRecord = presentationRecord.presentationParent() ? presentationRecord.presentationParent().presentationParent() : null; currentRecord; currentRecord = currentRecord.presentationParent())

paddingLeft += 12 / (Math.max(1, step++));

this.element.style.paddingLeft = paddingLeft + "px";

- if (record.thread() && record.thread() !== "CPU")

+ if (record.thread() !== WebInspector.TimelineModel.MainThreadName)

this.element.classList.add("background");

this._typeElement.textContent = uiUtils.titleForRecord(record);

@@ -1194,7 +1194,7 @@ WebInspector.TimelineRecordGraphRow.prototype = {

this._record = presentationRecord;

var record = presentationRecord.record();

this.element.className = "timeline-graph-side timeline-category-" + uiUtils.categoryForRecord(record).name;

- if (record.thread() && record.thread() !== "CPU")

+ if (record.thread() !== WebInspector.TimelineModel.MainThreadName)

this.element.classList.add("background");

var barPosition = calculator.computeBarGraphWindowPosition(presentationRecord);